[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: rpms/bonnie++/devel bonnie++-1.03a-gcc43.patch, NONE, 1.1 bonnie++.spec, 1.15, 1.16



On Mon, 11 Feb 2008 14:20:23 -0500, Warren Togami 砥上勇 (wtogami) wrote:

> Author: wtogami
> 
> Update of /cvs/pkgs/rpms/bonnie++/devel
> In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv2994
> 
> Modified Files:
> 	bonnie++.spec 
> Added Files:
> 	bonnie++-1.03a-gcc43.patch 
> Log Message:
> add katzj's gcc-4.3 build fix
> 
> 
> bonnie++-1.03a-gcc43.patch:
> 
> --- NEW FILE bonnie++-1.03a-gcc43.patch ---
> diff -up bonnie++-1.03a/zcav.cpp.gcc43 bonnie++-1.03a/zcav.cpp
> --- bonnie++-1.03a/zcav.cpp.gcc43	2008-02-08 20:19:25.000000000 -0500
> +++ bonnie++-1.03a/zcav.cpp	2008-02-08 20:19:37.000000000 -0500
> @@ -9,6 +9,7 @@ using namespace std;
>  #include <sys/stat.h>
>  #include <fcntl.h>
>  #include <stdlib.h>
> +#include <string.h>
>  #include "bonnie.h"
>  #ifdef HAVE_VECTOR
>  #include <vector>
> @@ -72,7 +73,7 @@ int main(int argc, char *argv[])
>            usage();
>          userName = strdup(optarg);
>          int i;
> -        for(i = 0; userName[i] && userName[i] != ':'; i++);
> +        for(i = 0; userName[i] && userName[i] != ':'; i++) ;
>          if(userName[i] == ':')
>          {
>            if(groupName)

That makes no sense. Remove the ';' for the real fix (and optionally
put explicit braces around the if-block).


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]