[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Massrebuilds for GCC 4.3 coming soon to a buildsystem near you!



On 02/13/2008 10:45 AM, Hans de Goede wrote:

Attached is a patch which fixes this by un-inlining the Collision constructor. Actually it seems that the best way to fix this is to un-inline all Collision members which use the template and move the template entirely to Collision.cpp

And since you are using C++, don't hesitate to take advantage of initialization list, either. E.g.:

+  CollisionSystem::CollisionSystem()
+     : m_pGrid(NULL), m_bDebugFlag(false)
+  {
+  }

Since you're using templates, it may be a win in this specific case (I haven't looked too deeply), but nonetheless it is a good habit to get into as it can have performance benefits. Just make sure you keep the list in the same order as declared in the class.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]