[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Kernel headers changes in F10?



On Mon, 2008-06-02 at 11:05 +0100, Bastien Nocera wrote:
> Heya,
> 
> I'm having trouble compiling the GStreamer V4L2 plugin on F10, when it
> work perfectly for the exact same source in F9.
> 
> F10:
> http://koji.fedoraproject.org/koji/getfile?taskID=640403&name=build.log
> F9:
> http://koji.fedoraproject.org/koji/getfile?taskID=640384&name=build.log
> 
> Any changes somebody knows of?

Rather than a link to a huge text file, it might have been useful to
include the failure mode, which is this:

v4l2_calls.c:268: error: 'V4L2_CID_HCENTER' undeclared (first use in this function)
v4l2_calls.c:268: error: (Each undeclared identifier is reported only once
v4l2_calls.c:268: error: for each function it appears in.)
v4l2_calls.c:269: error: 'V4L2_CID_VCENTER' undeclared (first use in this function)

A few moments with git-annotate showed that the missing ioctls were
removed in commit 26d507fcfef7f7d0cd2eec874a87169cc121c835¹ by Brandon
Philips. In their place, we have the following:

/* Deprecated, use V4L2_CID_PAN_RESET and V4L2_CID_TILT_RESET */
#define V4L2_CID_HCENTER_DEPRECATED     (V4L2_CID_BASE+22)
#define V4L2_CID_VCENTER_DEPRECATED     (V4L2_CID_BASE+23)

That seems like a rather dubious change to the user API -- shouldn't we
ensure that existing software continues to build, but maybe add a
compile-time or run-time warning for those using the deprecated ioctls?

Mauro, Brendan: unless the removal of those ioctls has been properly
documented in Documentation/feature-removal-schedule.txt for an
appropriate amount of time, please could you put them back as they were.
Changing the userspace API like this isn't acceptable.

-- 
dwmw2

¹ http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=26d507fc


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]