[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: make clog slowdown in devel.



On Saturday 21 June 2008, Dave Jones wrote:
> On Fri, Jun 20, 2008 at 10:07:33PM -0400, Jeremy Katz wrote:
>  > On Fri, 2008-06-20 at 18:29 -0400, Dave Jones wrote:
>  > > I noticed something odd..
>  >
>  > [snip]
>  >
>  > > The times are consistent across multiple runs. Same command in devel
>  > > takes a lot longer.  The spec file differences are irrelevant.
>  > > (tested by copying the specfile from f9 to devel)
>  > >
>  > > The clog target is just a simple sed & tee, so I'm confused as to why
>  > > it takes longer.
>  >
>  > I suspect it's due to the fact that we don't have a branch file and so
>  > do more checking for figuring out what branch you're on (which is used
>  > to determine the value of %dist among other things)
>
> I tried faking one. Didn't change anything..
>
> $ echo F-10 > branch
[...]

Makefile.common doesn't seem to be looking at the "branch" file at all to 
figure out the branch, instead it does a "pwd | awk -F '/' '{ print $NF }'".

And as Jeremy noted, if the branch is "devel", a subsequent "cvs rlog" is done 
before anything else which I'm pretty sure is the slowdown culprit.  I wonder 
if it would be feasible to modify Makefile.commmon to do that only when 
needed so frequently run targets that don't need the branch/dist info 
wouldn't be affected.  Or just disable the rlog thingy during times when no 
early branching for the next release is being done (I suppose that's what it 
is all about).


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]