[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Mass rebuild for F13?

Jesse Keating <jkeating j2solutions net> writes:
> On Dec 21, 2009, at 4:38, Orcan Ogetbil <oget fedora gmail com> wrote:
>> Seriously, this "comment about the patch in the specfile" is a
>> packaging requirement, not a personal request.

> With git style patches (and others) where there is lots of context and  
> info in the patch file itself, duplicating it into the spec file is  
> rather pointless. Let's have some thinking about the guidelines  
> instead of blind following. The guideline is there so that we don't  
> just have raw diffs without any context.

Yeah, I much prefer to put comments in the patch file too.  For one
thing, they're much more likely to get updated when the patch changes
that way.  The packaging guideline seems to be written with one-liner
comments in mind, but my comments often run to more than that.

			regards, tom lane

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]