[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: rpms/sylpheed/devel import.log, 1.1, 1.2 sylpheed.spec, 1.100, 1.101



On Tue, 28 Jul 2009 19:48:42 +0200, Josephine wrote:

> from dif cvs
> -%define tarversion 2.6.0
> +%global tarversion 2.7.0
> 
> you don't need to switch from define to global (
> http://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define)
> if 2 macros, %{tarversion} and %{version}, are using the same content
> "2.7.0"
> 
> please remove tarversion to keep that clean!

No, don't.  %tarversion is in there on purpose. For beta/rc releases,
%version and %tarversion differ. It doesn't make much sense to remove such
a variable and its usage in several places only to put it back when
necessary.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]