[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Removing %clean



On Di Mai 26 2009, Tom "spot" Callaway wrote:
> On 05/26/2009 04:10 AM, Richard W.M. Jones wrote:

>  * Set the BuildRoot to / and cause massive system destruction

What about setting BuildRoot to /home or /etc, this would case similiar 
massive system destruction?

> %__spec_install_pre %{___build_pre}\
>     [ "$RPM_BUILD_ROOT" != "/" ] && rm -rf "${RPM_BUILD_ROOT}"\
>     mkdir -p `dirname "$RPM_BUILD_ROOT"`\
>     mkdir "$RPM_BUILD_ROOT"\
> %{nil}



> BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
> ...
>
> %install
> rm -rf %{buildroot}
> make DESTDIR=%{buildroot} install
> ...
>
> %clean
> rm -rf %{buildroot}
> ...
>
> TO:
>
> ...
> %install
> make DESTDIR=%{buildroot} install
> ...
> %clean
> ...
>
> Is anyone opposed to that?

I am not, but it is a little strange to me that now that rpm is fixed that 
there is no race condition by default with "mkdir $RPM_BUILD_ROOT", why is it 
then possible to fix this for older versions of rpm in Fedora? This has 
already been discussed atleast in March 2007 on the Fedora packaging 
mailinglist. Nevertheless, please do this change. :-)

Regards
Till

Attachment: signature.asc
Description: This is a digitally signed message part.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]