Removing %clean

[Michael Schwendt]

On Tue, 26 May 2009 16:51:01 -0400, Bill wrote:

> Till Maas said: 
> > On Di Mai 26 2009, Tom "spot" Callaway wrote:
> > > On 05/26/2009 04:10 AM, Richard W.M. Jones wrote:
> > 
> > >  * Set the BuildRoot to / and cause massive system destruction
> > 
> > What about setting BuildRoot to /home or /etc, this would case similiar 
> > massive system destruction?
> 
> Well, also only if you're building as root. Which you shouldn't do
> anyways.

"rm -rf /home" for a normal user would remove the user's home directory.

The added risk for building as root user is due to bugs which may damage
the system installation because the buildroot is not a chroot. The
software that is built is not forced to install into the buildroot.  It is
asked to respect parameters like DESTDIR="$RPM_BUILD_ROOT" (provided that
$DESTDIR is supported, which is not true in all cases), but that doesn't
protect against bugs. It has happened before, for example, that unexpanded
[or wrongly expanded] variables caused a build framework to remove wrong
paths.