[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Review request...



>>
> Hm... on a very quick first look, you obviously don't follow
> https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Release
> Your release should look something like 0.x.BETA4, not just BETA4. Plus
> every time you update the SPEC, you should also increase the x ;-)
>
> I'm not sure if it's explicitly in the guidelines somewhere or not
> (haven't ever used this kind of thing myself), but you appear to
> generate subpackages based on some build time conditionals -- (at least
> IMHO) it's not a good approach. Do you really need these conditionals
> anyway? Why not just build all the subpackages that are worth building?
>
> Martin
>


Can you post this info in the bug report ?



-- 
------------

Itamar Reis Peixoto

e-mail/msn/google talk/sip: itamar ispbrasil com br
skype: itamarjp
icq: 81053601
+55 11 4063 5033
+55 34 3221 8599


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]