[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: memset bugs.



On Wed, Nov 25, 2009 at 01:58:38PM -0500, Jakub Jelinek wrote:
 > On Wed, Nov 25, 2009 at 01:43:13PM -0500, Dave Jones wrote:
 > > There's some obvious bugs below in a bunch of packages.
 > > The 2nd and 3rd arguments to memset calls are the wrong way around.
 > > I found these after grepping through a make prep'd devel/ tree.
 > > 
 > > 15 hits out of 100G of source code isn't that bad, but we can do better!
 > 
 > glibc headers warn about this (when -D_FORTIFY_SOURCE=2), so a faster way
 > would be just grep through all packages' build.log files (preferrably on the
 > box where they are stored to avoid downloading it all).

Can we make it fail the build instead of warning ?
A zero sized memset is always a bug.

	Dave


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]