[Fedora-directory-devel] Please review: bug 175170: Directory Server Admin Server Dies after Secure Bind to Directory Server

[Richard Megginson]

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175170
Bug(s) fixed: 175170
Bug Description: Directory Server Admin Server Dies after Secure Bind to 
Directory Server
Reviewed by: ???
Files: mod_admserv.c
Branch: HEAD
Fix Description: This fix makes the assumption that mod_nss will always 
be used.  It is possible to use mod_admserv without mod_nss - this would 
mean that the admin server accepts http, but uses ldaps to communicate 
with the DS.  However, I don't forsee that happening, so in order to 
simplify things, this fix makes mod_nss resposible for initializing NSS 
and shutting it down properly.
Another problem was the memory and resource leaks.  pset's have to be 
disposed of after use.  This appears to have been a problem in the old 
NES libAdmservPlugin as well since most of the code was just 
copied/pasted.  There were also a couple of other memory leaks.
NOTE: This is only part of the total fix, which will involve changes to 
mod_nss, ldap sdk, and admin server components.
Platforms tested: FC4
Flag Day: no
Doc impact: no
https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=123293