[Fedora-directory-devel] Please review: Bug 204623: deleting attributes when changing password causes server crash

[Richard Megginson]

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204623
Bug(s) fixed: 204623
Bug Description: deleting attributes when changing password causes 
server crash
Reviewed by: ???
Files: see diff
Branch: HEAD
Fix Description: From Michal: "The function mod2smod does not check for 
mod->mod_bvalues being NULL and tries
to dereference it (modutil.c:370). This function happens to be called 
only by
slapi_mods_get_{first,next}_smod(), which are in turn called only by
check_trivial_words() in pw.c; this is why the crash appears only when 
checking
password syntax."
I added the same check for the mod_values case - even though the
code says this should never be called, better to be safe than sorry.
Platforms tested: RHEL4
Flag Day: no
Doc impact: no
https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=138386

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3178 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/fedora-directory-devel/attachments/20061012/eb4e401a/attachment.bin>