[Fedora-directory-devel] Please review: Bug 206450: pass thru auth plugin should be configured by default

[Rob Crittenden]

I have mixed feelings. It duplicates a fair bit of code but then again, 
it is moderately clear why. Would it be overly complex to merge these, 
something like:

     if (cf->use_existing_config_ds || cf->use_existing_user_ds)
     {
         LDAPURLDesc *desc = 0;
         char *url = cf->use_existing_config_ds ? cf->config_ldap_url :
             cf->user_ldap_url;
         char *suffix = NULL;

         if (url && !ldap_url_parse(url, &desc) && desc)
         {
             suffix = desc->lud_dn;
             char *service = !strncmp(url, "ldaps:", strlen("ldaps:")) ?
                 "ldaps" : "ldap";
             if (cf->use_existing_config_ds)
             {
                 suffix = cf->netscaperoot;
             }

             suffix = ds_URL_encode(suffix);
         }
         fprintf ...
         fprintf(f, "nsslapd-pluginenabled: %s\n", "on" : suffix ? "off");
         if ( suffix ) {
             fprintf(f, "nsslapd-pluginarg0: %s://%s:%d/%s\n", service, 
desc->lud_host, desc->lud_port, suffix);
             free(suffix);
             ldap_free_urldesc(desc);

         }
         ...

rob

Richard Megginson wrote:
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206450
> Bug(s) fixed: 206450
> Bug Description: pass thru auth plugin should be configured by default
> Reviewed by: ???
> Files: see diff
> Branch: HEAD
> Fix Description: If you do a core DS build, you don't have a config DS 
> or a user DS, and
> therefore the pass thru auth plugin is not added to the server config.  It
> should always be added, disabled if not used immediately.  The fix is to 
> add it in this case, disabled.
> Platforms tested: RHEL4
> Flag Day: no
> Doc impact: no
> https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=136265
> 
> 
> ------------------------------------------------------------------------
> 
> --
> Fedora-directory-devel mailing list
> Fedora-directory-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/fedora-directory-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3178 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/fedora-directory-devel/attachments/20060914/180a0ce4/attachment.bin>