[Fedora-directory-devel] Please Review: (251262) ldap-agent needs to find slapd.stats file dynamically

[Nathan Kinder]

Rich brought up a good point in the bug report about the need to handle
wrapped lines in the dse.ldif.

This new set of diffs addresses this concern by using the ldif parsing
functions from the libldif library that is part of the Mozilla LDAP C 
SDK.  I
also did some error checking cleanup, particularly ensuring that we 
close any
files that we opened if we encounter an error condition while processing the
config.

I have also tested that these changes work when there is a wrapped line for
one of the attributes that we read in dse.ldif.

https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=160880&action=diff

Nathan Kinder wrote:
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251262
> Resolves: bug 251262
> Bug Description: Our SNMP subagent (ldap-agent) currently requires a 
> full path to
>  a DS instance in it's config file.  It is hardcoded to look in the 
> log subdirectory
>  for the slapd.stats file.  It also uses expects a config subdirectory 
> to find the
>  dse.ldif.  This will no longer work now that DS has been restructured 
> to follow
> FHS standards.
> Reviewed by: ???
> Files: see diff
> Branch: HEAD
> Fix Description: The proposed fix changes the ldap-agent config to 
> simply expect
>  the instance name (i.e - slapd-foo).  The subagent will then use this 
> instance
>  name to load the dse.ldif from the proper location in 
> $SYSCONFDIR/$PACKAGE_NAME.
>  The subagent will look up the value of nsslapd-tmpdir to find out 
> where the
>  slapd.stats file is for that particular instance.  I also improved 
> the error
>  checking around processing the ldap-agent config file.
> Platforms tested: FC6
> Flag Day: no
> Doc impact: Yes.  A bug will be opened to change the documentation of 
> the ldap-agent "server" config parameter.
> https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=160867&action=diff
> ------------------------------------------------------------------------
>
> --
> Fedora-directory-devel mailing list
> Fedora-directory-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/fedora-directory-devel
>   

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3241 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/fedora-directory-devel/attachments/20070807/99bf1b53/attachment.bin>