[Fedora-directory-devel] Please review: Bug 229691: Add enable switches for optional/experimental features

[Richard Megginson]

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229691
Resolves: bug 229691
Bug Description: Add enable switches for optional/experimental features
Reviewed by: ???
Files: see diff
Branch: HEAD
Fix Description: Added --enable-pam-passthru, --enable-dna, and 
--enable-ldapi.  They are all on by default and must be explicitly 
disabled (--disable-pam-passthru).  These all cause ENABLE_xxx to be 
defined for C code so that we can enclose the code in #ifdef 
ENABLE_PAM_PASSTHRU blocks, for example.  For the first two, these also 
cause the plugins to be built - so that if you specify 
--disable-pam-passthru, the plugin code will not be built at all.  I 
discovered a nifty autoconf macro called AS_HELP_STRING - this nicely 
formats the help messages output by configure --help.  I don't know if 
it's worth going through all of our m4 code to use this, but I went 
ahead and fixed configure.ac.  Create instance will now add plugin 
configuration entries (but disabled) for pam passthru and dna if the 
corresponding ENABLE_ macros are defined.  I also fixed a bug with 
passthru (not pam passthru) - the plugin configuration entry was not 
being added.
Platforms tested: RHEL4, FC6
Flag Day: no
Doc impact: no
https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=148631&action=diff
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/fedora-directory-devel/attachments/20070222/84c942e6/attachment.bin>