[Fedora-directory-devel] Please review: Bug 248145: Replace ds_newinst binary with perl script

[Richard Megginson]

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248145
Resolves: bug 248145
Bug Description: Replace ds_newinst binary with perl script
Reviewed by: ???
Files: see diff
Branch: HEAD
Fix Description: The time has come.  We can finally get rid of the 
instance creation C code
 once and for all.  I've created a DSCreate module that has all of the 
functionality of the old
 create_instance.c code, along with a few items from ldap/admin/lib.  
The way it works is
 this: it first creates the dse.ldif file using template-dse.ldif and 
the suffix-db template to
 create the initial db and suffix.  It then adds additional optional 
configuration depending
 on what optional features have been enabled.  It creates other config 
files and copies in
 the schema.  It then initializes the database.  It uses a template file 
based on the type of
 entry implied by the suffix, then adds the default ACIs.  If the user 
chose to do so, it
 will also create the ou=people, ou=groups, etc. entries.  The user can 
also supply an LDIF
 file which will be used to populate the initial database, in which case 
none of the default
 entries or ACIs will be used.  It then starts the server (if desired).
 I had to create a function makePaths that works like mkdir -p except 
that it will chown,
 chgrp, and chmod all paths created.
 I had to change the other places where instance creation was called to 
use the new
 calling semantics.  ds_create changed quite a bit, since it can just 
use an Inf to pass in the
 information instead of calling ds_newinst as a CGI program.
 I had to change FileConn to add support for namingContexts (i.e. 
entries with no parent),
 and to have it write each change each time, and to return copies of 
entries when searching,
 to avoid modifying the tree in place.  This makes it act much more like 
LDAP.
 I found and fixed a few bugs in Migration along the way that were 
revealed while integrating
 the new DSCreate code.
Platforms tested: RHEL4, FC6
Flag Day: Yes.  New instance creation code and autotool changes.
Doc impact: no
QA impact: should be covered by regular nightly and manual testing
New Tests integrated into TET: none
https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=159175
https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=159187&action=diff
https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=159188&action=diff

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/fedora-directory-devel/attachments/20070713/7543149e/attachment.bin>