[389-devel] Bug in windows replication

[Peter Sandström]

The entry is added before the check for wierd values, causing it to fail.

The following patch fixes it.

diff -ru fedora-ds-base-1.2.0-orig/ldap/servers/plugins/replication/windows_connection.c
fedora-ds-base-1.2.0/ldap/servers/plugins/replication/windows_connection.c
--- fedora-ds-base-1.2.0-orig/ldap/servers/plugins/replication/windows_connection.c
    2008-12-05 17:41:52.000000000 -0500
+++ fedora-ds-base-1.2.0/ldap/servers/plugins/replication/windows_connection.c
 2009-07-28 05:13:40.564546527 -0400
@@ -542,7 +542,6 @@
        for ( a = ldap_first_attribute( ld, msg, &ber ); a!=NULL;
a=ldap_next_attribute( ld, msg, ber ) )
        {
                struct  berval ** aVal = ldap_get_values_len( ld, msg, a);
-               slapi_entry_add_values(rawentry, a, aVal);

                if (0 == strcasecmp(a,"dnsRecord") || 0 ==
strcasecmp(a,"dnsproperty") ||
                    0 == strcasecmp(a,"dscorepropagationdata"))
@@ -556,6 +555,7 @@
                        ;
                } else
                {
+                       slapi_entry_add_values(rawentry, a, aVal);
                        if (attrsonly)
                        {
                                slapi_entry_add_value(e, a,
(Slapi_Value *)NULL);


-- 
Peter Sandström
Head of Operations, Stardoll AB
phone: +46 (0)70 456 05 28
e-mail: peter at stardoll.com | stardoll: pj0tr
mail/visit: Hudiksvallsgatan 8, 113 30 Stockholm, Sweden
www.stardoll.com - Fame, fashion and friends