[389-devel] Commit: [PATCH] Add Simple Paged Results

[Noriko Hosoi]

Thanks to Rich for his reviews.  Revised diff is uploaded at: 
http://nhosoi.fedorapeople.org/0001-Add-Simple-Paged-Results.patch

The patch has been pushed to master.

$ git merge pagedresults
Auto-merged Makefile.in
Auto-merged configure
Merge made by recursive.
 Makefile.am                                    |    2 +
 Makefile.in                                    |   54 +-
 ldap/servers/slapd/back-ldbm/filterindex.c     |   17 +-
 ldap/servers/slapd/back-ldbm/init.c            |    2 +
 ldap/servers/slapd/back-ldbm/ldbm_search.c     |  174 +++-
 ldap/servers/slapd/back-ldbm/proto-back-ldbm.h |    5 +-
 ldap/servers/slapd/back-ldbm/sort.c            |   79 +--
 ldap/servers/slapd/backend.c                   |    6 +
 ldap/servers/slapd/connection.c                |   35 +-
 ldap/servers/slapd/control.c                   |   29 +-
 ldap/servers/slapd/daemon.c                    |   10 +
 ldap/servers/slapd/opshared.c                  | 1242 
+++++++++++++-----------
 ldap/servers/slapd/pagedresults.c              |  315 ++++++
 ldap/servers/slapd/pblock.c                    |   12 +
 ldap/servers/slapd/proto-slap.h                |   19 +
 ldap/servers/slapd/result.c                    |   21 +-
 ldap/servers/slapd/slap.h                      |   19 +
 ldap/servers/slapd/slapi-private.h             |    3 +
 ldap/servers/slapd/sort.c                      |  130 +++
 19 files changed, 1454 insertions(+), 720 deletions(-)
 create mode 100644 ldap/servers/slapd/pagedresults.c
 create mode 100644 ldap/servers/slapd/sort.c

$ git push
Counting objects: 55, done.
Compressing objects: 100% (29/29), done.
Writing objects: 100% (29/29), 13.90 KiB, done.
Total 29 (delta 25), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
   0235f43..902fe2d  master -> master

Thanks,
--noriko

Noriko Hosoi wrote:
> Rich Megginson wrote:
>> Noriko Hosoi wrote:
>>> The patch is located here (It's too big for email...):
>>> http://nhosoi.fedorapeople.org/0001-Add-Simple-Paged-Results.patch
>> In pagedresults.c there are several functions that get/set 
>> Connection* internals - are these protected by conn->c_mutex?  Do 
>> they need to be?
> A good point.  Updates are done by one thread, but the values could be 
> read by other threads.  I'm going to add them and run some more 
> tests.  Thanks, Rich!
> --noriko
>>
>> Otherwise, looks good.
>>>
>>> I also updated the design doc on wiki:
>>> http://directory.fedoraproject.org/wiki/Simple_Paged_Results_Design
>>>
>>> Comments on the doc would be appreciated, too.
>>>
>>> Thanks,
>>> --noriko
>>> ------------------------------------------------------------------------ 
>>>
>>>
>>> -- 
>>> Fedora-directory-devel mailing list
>>> Fedora-directory-devel at redhat.com
>>> https://www.redhat.com/mailman/listinfo/fedora-directory-devel
>>>   
>>
>> ------------------------------------------------------------------------
>>
>> -- 
>> Fedora-directory-devel mailing list
>> Fedora-directory-devel at redhat.com
>> https://www.redhat.com/mailman/listinfo/fedora-directory-devel
>>   
>
> ------------------------------------------------------------------------
>
> --
> Fedora-directory-devel mailing list
> Fedora-directory-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/fedora-directory-devel
>   

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3250 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/fedora-directory-devel/attachments/20090515/529e984b/attachment.bin>