[Fedora-electronic-lab] Re: [Fedora Electronic Lab] #23: Package qtdmm

[Fedora Electronic Lab]

#23: Package qtdmm
----------------------------+-----------------------------------------------
  Reporter:  zap            |       Owner:  sherry151
      Type:  task           |      Status:  new      
  Priority:  minor          |   Milestone:  Fedora 12
 Component:  analog design  |     Version:  devel    
Resolution:                 |    Keywords:           
----------------------------+-----------------------------------------------
Comment (by chitlesh):

 Replying to [comment:7 zap]:
 > sherry151, thanks very much for review! Especially for the rpmlint hint,
 this seems a nice tool to avoid childish packaging problems.
 >
 > I have fixed almost all mentioned problems and will upload the spec file
 shortly.
 >
 > Also I've updated the src.rpm here:
 > http://cs.ozerki.net/zap/pub/rpm/qtdmm-0.8.12-1.fc9.zap.src.rpm
 >
 > Only a few objections:
 >
 >  * Still I would like to keep the older changelog to credit the original
 spec file author. This is imho a matter of fairness, but if you insist I
 will remove it.

 I said above they should be kept.

 >  * 'Requires qt3' is needed because it's a bit of difference between
 Requires and Build-Requires.



 #1: warning: deprecated conversion from string constant to ‘char*’[[BR]]
 can you patch this ?

 #2: fix the desktop-file-install, see sherry's spec so that the desktop
 file gets into the Electronic section.

 #3: changelog adopt the same changelog style as sherry did. The version-
 release at the end of the line + an empty line in between two changelog
 entry.

 #4: same, add empty lines to separate different blocks of the spec.
 Although this is not critical for the package, it makes the spec file hard
 to read without spending too much time. See sherry's spec again or my spec
 file on http://chitlesh.fedorapeople.org/RPMS/

-- 
Ticket URL: <https://fedorahosted.org/fedora-electronic-lab/ticket/23#comment:8>
Fedora Electronic Lab <https://fedorahosted.org/fedora-electronic-lab>
Design, Simulate and Program electronics.