[Fedora-electronic-lab] Re: [Fedora Electronic Lab] #19: package a 8051 ide (spec included)

[Fedora Electronic Lab]

#19: package a 8051 ide  (spec included)
------------------------------+---------------------------------------------
  Reporter:  chitlesh         |       Owner:  chitlesh 
      Type:  task             |      Status:  new      
  Priority:  major            |   Milestone:  Fedora 12
 Component:  embedded design  |     Version:  devel    
Resolution:                   |    Keywords:           
------------------------------+---------------------------------------------
Changes (by chitlesh):

  * type:  defect => task

Comment:

 Thanks,

 Well it is a fair simple package to start packaging. If you have not yet
 sponsored for Fedora packaging, let me know I will sponsor you.

 Below are some package review comments. I recommend you to update the spec
 as appropriate and file an official package review requests as suggested
 on :
 https://fedoraproject.org/wiki/PackageMaintainers

 Btw, you can use your 150Mb space on FAS_USERNAME.fedorapeople.org, to
 upload your spec and SRPMS.


 #01: ChangeLog
 Can you add this:

 * Wed May 20 2009 Chitlesh Goorah <chitlesh [AT] fedoraproject DOT org> -
 1.1-1
 - Initial Package

 below your changelog entry.

 Tip: your spec file will be archived on different mirrors and some of them
 don't have spam protection, I recommend you to use the "email format" I
 used above to cheat spammers.

 Your release tag should be _currently_ 2. Everytime you do some
 modifications on the spec just increment the release tag and avoid adding
 decimal value.

 #02: Source URL

 In accordance to the https://fedoraproject.org/wiki/Packaging:Guidelines,
 the source URL should be:
 http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz


 #03: Avoid unneccessary requires:

 Yum and RPM are both intelligent to deduce which RPMS to require. So you
 can remove:

 Requires:       tcl >= 8.4, tk >= 8.4, tkimg >= 1.3, itcl >= 3.1, tdom >=
 0.8, tcllib >= 1.6, bwidget >= 1.8, rxvt-unicode >= 8.3

 Tip: to know whether the proper dependencies will be pulled by yum, do:

 $ rpm -qpR NVR.arch.disttag.rpm

 NVR = NAME-VERSION-RELEASE

 Tip: Requires: electronics-menu should be explicit added due to the menu-
 structure

 # 04: Avoid versions on BuildRequires/Requires
 Unless it is really needed, you should avoid adding versions on
 BuildRequires and Requires. This is one of the reasons why users have
 problem while upgrading from F-N to F-(N+1).

 # 05: Avoid redundant BuildRequires:
 Again, yum is intelligent :)
 for example, tk-devel already requires tcl-devel, so you can remove tcl-
 devel from BR.

 To know if tcl-devel(or another package) is required by tk-devel

 $ rpm-qR tk-devel
 ...
 tcl-devel <-----------------
 ...

 Use the same method to remove buildrequires duplicates. In some cases it
 helps to reduce time during yum install or yum update.

 # 06: What I called: make-it-sexy :)

 - either use $RPM_BUILD_ROOT or %{buildroot}

 #07: backup

 add a "-b .desktop" after %patch0 -p1


 The package looks fine and there are not real blockers for its approval.
 It's only fedora packaging guidelines to get familiar with, if not good
 job Shakthi.


 Once you have updated the spec file, file an official package review
 request and give me the url. I will review it for you. I think we can get
 it into fedora mirrors before this weekend. Unfortunately, it is a bit too
 late to add it into the livedvd. :(

 After the package has been approved, remind me to show you how to add any
 package on the FEL livedvd.

-- 
Ticket URL: <https://fedorahosted.org/fedora-electronic-lab/ticket/19#comment:2>
Fedora Electronic Lab <https://fedorahosted.org/fedora-electronic-lab>
Design, Simulate and Program electronics.