rpms/rsnapshot/devel rsnapshot.spec,1.2,1.3

[Michael Schwendt]

On Tue, 12 Apr 2005 15:22:07 +0200, Ralf Corsepius wrote:

> On Tue, 2005-04-12 at 07:54 -0400, Gavin Henry wrote:
> > Author: ghenry
> > 
> > Update of /cvs/extras/rpms/rsnapshot/devel
> > In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv12551/devel
> > 
> > Modified Files:
> > 	rsnapshot.spec 
> > Log Message:
> > auto-import rsnapshot-1.2.1-2 on branch devel from rsnapshot-1.2.1-2.src.rpm
> > Updated specfile.
> > 
> > 
> > Index: rsnapshot.spec
> 
> >  AutoReqProv:    no
> 
> Why? "AutoReqProv: no" almost always is harmful to dependencies - I
> don't see any reason why it should be applied in this case.
> 
> As it seems to me, this package is not architecture-dependent and
> therefore probably should be "BuildArch: noarch".

If the old bugzilla.fedora.us ticket doesn't comment on it (I don't
see this in the copy of Erik's old spec file) and if it's not used
to avoid wrong/optional dependencies, it's a bug. Erik's package was
noarch, and the review commented on some of the issues, like %verify
usage.


To put it bluntly, RPM packages provided by upstream project's authors or
contributors are often (often, not always) full of crap. It has been a
common mistake in fedora.us submissions before to just copy a src.rpm from
a site and think it's a good package just because it looks fairly
elaborate.

This is where the reviewing process should start. If you copy from an
existing src.rpm or spec file, read it carefully. Try to understand every
line, every patch, every single statement or RPM macro, before you decide
to use something as a base for your own packaging.