rpms/rsnapshot/devel rsnapshot.spec,1.2,1.3

[Ralf Corsepius]

On Tue, 2005-04-12 at 16:19 +0200, Michael Schwendt wrote:
> On Tue, 12 Apr 2005 15:22:07 +0200, Ralf Corsepius wrote:
> 
> > On Tue, 2005-04-12 at 07:54 -0400, Gavin Henry wrote:
> > > Author: ghenry
> > > 
> > > Update of /cvs/extras/rpms/rsnapshot/devel
> > > In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv12551/devel
> > > 
> > > Modified Files:
> > > 	rsnapshot.spec 
> > > Log Message:
> > > auto-import rsnapshot-1.2.1-2 on branch devel from rsnapshot-1.2.1-2.src.rpm
> > > Updated specfile.
> > > 
> > > 
> > > Index: rsnapshot.spec
> > 
> > >  AutoReqProv:    no
> > 
> > Why? "AutoReqProv: no" almost always is harmful to dependencies - I
> > don't see any reason why it should be applied in this case.
> > 
> > As it seems to me, this package is not architecture-dependent and
> > therefore probably should be "BuildArch: noarch".
> 
> If the old bugzilla.fedora.us ticket doesn't comment on it (I don't
> see this in the copy of Erik's old spec file) and if it's not used
> to avoid wrong/optional dependencies, it's a bug. 
Let me put it this way:

rpm -qlvp i386/rsnapshot-1.2.1-3.i386.rpm
-rw-------    1 root    root             5337 Apr 12 15:17 /etc/rsnapshot.conf
-rw-r--r--    1 root    root             5337 Apr 12 15:17 /etc/rsnapshot.conf.default
-rwxr-xr-x    1 root    root           153295 Apr 12 15:17 /usr/bin/rsnapshot
drwxr-xr-x    2 root    root                0 Apr 12 15:17 /usr/share/doc/rsnapshot-1.2.1
-rw-r--r--    1 root    root             1298 Apr 10 00:22 /usr/share/doc/rsnapshot-1.2.1/AUTHORS
-rw-r--r--    1 root    root            18004 Apr 10 00:22 /usr/share/doc/rsnapshot-1.2.1/COPYING
-rw-r--r--    1 root    root            16924 Apr 10 00:22 /usr/share/doc/rsnapshot-1.2.1/ChangeLog
-rw-r--r--    1 root    root             5220 Apr 12 15:17 /usr/share/doc/rsnapshot-1.2.1/README
-rw-r--r--    1 root    root             1733 Apr 10 00:22 /usr/share/doc/rsnapshot-1.2.1/TODO
-rw-r--r--    1 root    root            10283 Apr 12 15:17 /usr/share/man/man1/rsnapshot.1.gz

=> All this package provides is a single perl script
(/usr/bin/rsnapshot)

I don't see much reason why a perl _script_ should be i386.

Removing the "Autoreqprov: no" tag lets the rpm additionally contain
some perl-module deps, instead of depending on a plain (and bogus)
"perl" - The remaining deps remain the same as before.

Ralf