rpms/octave-forge/devel octave-forge.spec, NONE, 1.1 .cvsignore, 1.1, 1.2 sources, 1.1, 1.2

[Michael Schwendt]

On Thu, 21 Apr 2005 12:20:04 -0400, Quentin Spencer wrote:

> Author: qspencer
> 
> Update of /cvs/extras/rpms/octave-forge/devel

> %build
> LC_ALL=POSIX
> export LC_ALL
> %define host_type %(echo "disp(octave_config_info('canonical_host_type'))" | octave -qf)
> %define site_dir octave/%{octave_ver}/site
> ## The paths are hardcoded by configure, so this ugly configure command
> ## is necessary to get them to install in the right places.
> ./configure --with-x --prefix=$RPM_BUILD_ROOT%{_prefix} \
> 	--mandir=$RPM_BUILD_ROOT%{_mandir} --libdir=%{_libdir} \
> 	--with-mpath=$RPM_BUILD_ROOT%{_datadir}/%{site_dir}/m/octave-forge \
> 	--with-opath=$RPM_BUILD_ROOT%{_libexecdir}/%{site_dir}/oct/%{host_type}/octave-forge \
> 	--with-xpath=$RPM_BUILD_ROOT%{_libexecdir}/%{site_dir}/exec/%{host_type} \
> 	--with-altpath=$RPM_BUILD_ROOT%{_datadir}/%{site_dir}/octave-forge-alternative/m \
> 	--with-altmpath=$RPM_BUILD_ROOT%{_datadir}/%{site_dir}/octave-forge-alternative/m/octave-forge \
> 	--with-altopath=$RPM_BUILD_ROOT%{_libexecdir}/%{site_dir}/octave-forge-alternative/oct/%{host_type}
> make %{?_smp_mflags}

$RPM_BUILD_ROOT at this position looks plain wrong, since it's way too
dangerous to increase the possibility that buildroot paths find their way
into the compiled binaries or any files created from *.in templates. Unless there
is a specific configure switch which accepts a buildroot argument, never (!) use
$RPM_BUILD_ROOT or %buildroot in the %build section.

> %install
> rm -rf $RPM_BUILD_ROOT
> make install 

Does the program not provide any way to install into a buildroot?
E.g. the standard "make install DESTDIR=$RPM_BUILD_ROOT"? If not, use
the %makeinstall macro and use the %configure macro in the %build
section. See /usr/lib/rpm/macros on what those two do exactly.

> %files
> %defattr(-,root,root)
> %doc COPYING* README RELEASE-NOTES TODO
> %doc doc/*.html doc/coda/*.sgml doc/coda/appendices/*.sgml
> %doc doc/coda/oct/*.sgml doc/coda/standalone/*.sgml
> %{_datadir}/octave/*
> %{_libexecdir}/octave/*

Missing directories if you include files like that. Use:

%{_datadir}/octave/
%{_libexecdir}/octave/

instead.

[Disclaimer: this is no full review. Just comments on cvs commit.]