devel/clearlooks clearlooks-0.4-dirs.patch, NONE, 1.1 clearlooks.spec, 1.2, 1.3
Ralf Corsepius
rc040203 at freenet.de
Thu Mar 17 03:21:33 UTC 2005
- Previous message (by thread): devel/clearlooks clearlooks-0.4-dirs.patch, NONE, 1.1 clearlooks.spec, 1.2, 1.3
- Next message (by thread): devel/galeon .cvsignore, 1.2, 1.3 galeon.spec, 1.5, 1.6 sources, 1.3, 1.4
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
On Wed, 2005-03-16 at 16:00 -0500, Ignacio Vazquez-Abrams wrote:
> Author: ivazquez
>
> Update of /cvs/extras/devel/clearlooks
> In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv13986
>
> Modified Files:
> clearlooks.spec
> Added Files:
> clearlooks-0.4-dirs.patch
> Log Message:
> Fix install issues
>
> clearlooks-0.4-dirs.patch:
>
> --- NEW FILE clearlooks-0.4-dirs.patch ---
> --- clearlooks-0.4/themes/Clearlooks-Olive/gtk-2.0/Makefile.in.orig 2005-03-16 15:05:43.149930536 -0500
> +++ clearlooks-0.4/themes/Clearlooks-Olive/gtk-2.0/Makefile.in 2005-03-16 15:05:58.706150174 -0500
> @@ -217,7 +217,7 @@
> uninstall-info-am:
> install-themeDATA: $(theme_DATA)
> @$(NORMAL_INSTALL)
> - test -z "$(themedir)" || $(mkdir_p) "$(DESTDIR)$(themedir)"
> + test -z "$(DESTDIR)$(themedir)" || $(mkdir_p) "$(DESTDIR)$(themedir)"
This patch doesn't seem correct to me for 2 reasons:
1. This patch hacks an automake-generated Makefile.in.
If something is broken in a configuration, you should edit the
Makefile.am and regenerate the Makefile.in, but you must not manually
edit Makefile.ins.
2. The patch doesn't make sense.
test -z "$(themedir)" and test -z "$(DESTDIR)$(themedir)"
are equivalent.
Ralf
- Previous message (by thread): devel/clearlooks clearlooks-0.4-dirs.patch, NONE, 1.1 clearlooks.spec, 1.2, 1.3
- Next message (by thread): devel/galeon .cvsignore, 1.2, 1.3 galeon.spec, 1.5, 1.6 sources, 1.3, 1.4
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
More information about the fedora-extras-commits
mailing list