rpms/centericq/devel centericq-libyahoo.patch, NONE, 1.1 centericq.spec, 1.10, 1.11

[Ralf Corsepius]

On Tue, 2005-05-24 at 03:05 -0400, Andreas Bierfert wrote:
> Author: awjb

> ===================================================================
> RCS file: /cvs/extras/rpms/centericq/devel/centericq.spec,v
> retrieving revision 1.10
> retrieving revision 1.11
> diff -u -r1.10 -r1.11
> --- centericq.spec	22 May 2005 23:19:31 -0000	1.10
> +++ centericq.spec	24 May 2005 07:05:03 -0000	1.11

>  %build
>  CFLAGS="-I/usr/include/openssl -I/usr/kerberos/include -I/usr/include ${RPM_OPT_FLAGS}" \

This line is very arguable:

* In autoconf based configurations -I<dir> options are not supposed to
be contained in CFLAGS. They should be part of CPPFLAGS or INCLUDES.

* Explicitly passing -I/usr/include to the compiler is a bug.

However, I see this package has more problems with its configuration,
which might make such hacks necessary :(

Ralf