rpms/exo/devel exo.spec, NONE, 1.1 .cvsignore, 1.1, 1.2 sources, 1.1, 1.2

[Kevin Fenzi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

>>>>> "Michael" == Michael Schwendt <bugs.michael at gmx.net> writes:

Michael> On Fri, 27 May 2005 23:29:32 -0400, Kevin Fenzi wrote:
>> Author: kevin
>> 
>> Update of /cvs/extras/rpms/exo/devel

Michael> Fails to build here for i386.

Michael> RPM build errors: File not found by glob:
Michael> /home/qa/tmp/rpm/tmp/exo-0.3.0-2-root-qa/usr/share/locale/*/*/libexo*.mo
Michael> File not found by glob:
Michael> /home/qa/tmp/rpm/tmp/exo-0.3.0-2-root-qa/usr/lib/python*/site-packages
Michael> File not found by glob:
Michael> /home/qa/tmp/rpm/tmp/exo-0.3.0-2-root-qa/usr/share/pygtk/*/defs/exo*/exo.defs

Yeah, sorry about that. It was a missing buildrequires for
pygtk2-devel.

>> checking for msgfmt... no

Michael> Missing "BuildRequires: gettext".

Added. 

>> checking for python version... 2.4

Michael> The spec file hardcodes a python2.3 path!

yeah. ;( Fixed. 

>> checking for headers required to compile python extensions... not
>> found
>> 
>> configure: WARNING: Couldn't find either PyGTK or the Python
>> headers, not building Python bindings

Michael> (!) Some build requirements missing?

yes, the pygtk2-devel buildrequires. 

>> %package devel Summary: Development tools for exo library Group:
>> Development/Libraries Requires: exo >= 0.3.0

Michael> Requires: %{name} = %{version}-%{release}

Fixed. 
 
>> %files %defattr(-,root,root) %doc %{_datadir}/gtk-doc/html/exo/*
>> %{_libdir}/lib*.so.* %{_datadir}/locale/*/*/libexo*.mo

>> %files devel %defattr(-, root, root) %{_includedir}/exo*
>> %{_libdir}/lib*.so %{_libdir}/lib*a %{_libdir}/pkgconfig/*.pc

Michael> This pkg-config file creates a dependency between exo-devel
Michael> and "Requires: libxfcegui4-devel"

Humm. Not sure I understand how. libxfcegui4-devel is a buildrequire,
but only libxfcegui4 is a runtime require. How is libxfcegui4-devel
being pulled in by the pkg-config file? I'm sure I'm missing something
there. 

>> %{_datadir}/gtk-doc

Michael> I believe your package should not own that directory, but
Michael> only its own files somewhere deeper within it. I see a few
Michael> other packages which also own this directory, but that should
Michael> not be taken as a good example.

Fixed. 

Michael> Also, I see you include the gtk-doc files in the main package
Michael> already, so it's duplicate.

Fixed. They have been removed from the main package and set as docs in
the devel package. 

>> %{_libdir}/python2.3/site-packages

Michael> (!)
Michael> Won't work with Python 2.4.

Agreed. Fixed. 

Matthias> Michael Schwendt wrote :

>> File not found by glob:
>> /home/qa/tmp/rpm/tmp/exo-0.3.0-2-root-qa/usr/share/locale/*/*/libexo*.mo

Matthias> And for this one, you should be using the %find_lang macro
Matthias> instead.

Agreed. However, the locale files are all 'libexo-0.3', not
'exo'. Hopefully that won't cause confusion. I can submit a bug report
upstream to get them to change it to exo. For now I have set it to use
%find_lang with the 'libexo-0.3' argument. 

Matthias> Matthias

kevin

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8 <http://mailcrypt.sourceforge.net/>

iD8DBQFCm1op3imCezTjY0ERApKkAJ4sXjL06FPggNsOkq2oJlyynFlP5gCfW+iX
KJdhJQxfQQs9o1x/QD57Xuo=
=rBtd
-----END PGP SIGNATURE-----