rpms/perl-Log-Dispatch/devel perl-Log-Dispatch.spec,1.2,1.3

Ralf Corsepius rc040203 at freenet.de
Sat Sep 24 03:47:55 UTC 2005


On Sat, 2005-09-24 at 01:28 +0100, José Pedro Oliveira wrote:
> Ralf Corsepius wrote:
> > On Thu, 2005-09-22 at 13:48 -0400, Jose Pedro Oliveira wrote:
> > 
> >>Author: jpo
> >>
> >>Update of /cvs/extras/rpms/perl-Log-Dispatch/devel
> >>In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv21370/devel
> >>
> >>Modified Files:
> >>	perl-Log-Dispatch.spec 
> >>Log Message:
> >>- Exclude mod_perl from the requirements list
> >>  (overkill for most applications using Log::Dispatch).
> > 
> > 
> > VETO
> > 
> > IMO, this decision is a fault and should be reverted. You are breaking
> > package dependencies. 
> 
> I disagree with your opinion and I believe my decision is correct.
>
> Reasoning:
> 
> 1) to create an ApacheLog dispatcher you need to supply an Apache
>    object (see
> http://search.cpan.org/dist/Log-Dispatch/lib/Log/Dispatch/ApacheLog.pm)
>
> 2) you can only obtain an Apache* object if your app is running
>    under mod_perl

ApacheLog.pm does not depend on mod_perl. It depends on
perl(Apache2::Log), which currently just happens to be provided by
mod_perl.

So, if you split out ApacheLog.pm into a separate sub package, the whole
problem is gone.

I.e. a new perl-Log-Dispatch-ApacheLog subpackage would
Require: perl(Apache2::Log)
which would cause installation to implicitly/indirectly pull-in
mod_perl.

> So, your app should be the one requiring mod_perl and not
> perl-Log-Dispatch.
> 
> Also, when installing this perl package using CPAN you are not
> required to install mod_perl (see Build.PL).
> 
> This kind of requirements nightmare can even get worst if we
> start to talk about Log::Log4perl which uses Log::Dispatch.
I am not familiar with Log::Log4perl, but I don't see where the problem
is.

AFAIS, the only part inside of the current perl-Log-Dispatch package
which indirectly depends on something inside of mod_perl is
ApacheLog.pm. 

I.e. this all is ordinary perl module dependencies.

> > If you find this dependency to be too annoying, you probably better
> > should consider to package 
> > %perl_vendordir/Log/Dispatch/ApacheLog.pm
> > into a separate subpackage.
> 
> This could be a solution if there are packages that need
> perl-Log-Dispatch to install mod_perl and apache (I never
> came across one).

Ralf






More information about the fedora-extras-commits mailing list