rpms/xfdesktop/devel xfdesktop-4.4.2-memleak.patch, NONE, 1.1 xfdesktop.spec, 1.21, 1.22

Kevin Fenzi (kevin) fedora-extras-commits at redhat.com
Tue Aug 12 04:01:19 UTC 2008


Author: kevin

Update of /cvs/extras/rpms/xfdesktop/devel
In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv7787

Modified Files:
	xfdesktop.spec 
Added Files:
	xfdesktop-4.4.2-memleak.patch 
Log Message:
Add partial memory leak patch (partially fixes #428662)


xfdesktop-4.4.2-memleak.patch:

--- NEW FILE xfdesktop-4.4.2-memleak.patch ---
diff -Nur xfdesktop-4.4.2.orig/modules/menu/desktop-menu-dentry.c xfdesktop-4.4.2/modules/menu/desktop-menu-dentry.c
--- xfdesktop-4.4.2.orig/modules/menu/desktop-menu-dentry.c	2007-11-17 12:31:43.000000000 -0700
+++ xfdesktop-4.4.2/modules/menu/desktop-menu-dentry.c	2008-08-11 21:49:14.000000000 -0600
@@ -173,6 +173,7 @@
         if(cmpname && g_ascii_strcasecmp(name, cmpname) < 0)
             break;
     }
+    g_list_free(items);
     
     gtk_menu_shell_insert(menu_shell, mi, i);
     
diff -Nur xfdesktop-4.4.2.orig/modules/menu/desktop-menuspec.c xfdesktop-4.4.2/modules/menu/desktop-menuspec.c
--- xfdesktop-4.4.2.orig/modules/menu/desktop-menuspec.c	2007-11-17 12:31:43.000000000 -0700
+++ xfdesktop-4.4.2/modules/menu/desktop-menuspec.c	2008-08-11 21:50:14.000000000 -0600
@@ -203,7 +203,7 @@
                 else
                     foundcat = NULL;
                 if(!foundcat) {
-                    g_ptr_array_free(revpath, FALSE);
+                    g_ptr_array_free(revpath, TRUE);
                     revpath = NULL;
                     break;
                 }
@@ -220,7 +220,7 @@
                 newpath[totlen] = 0;
                 
                 g_ptr_array_add(mtfpi->paths, newpath);
-                g_ptr_array_free(revpath, FALSE);
+                g_ptr_array_free(revpath, TRUE);
             }
         }
     }


Index: xfdesktop.spec
===================================================================
RCS file: /cvs/extras/rpms/xfdesktop/devel/xfdesktop.spec,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -r1.21 -r1.22
--- xfdesktop.spec	20 Feb 2008 03:58:56 -0000	1.21
+++ xfdesktop.spec	12 Aug 2008 04:00:49 -0000	1.22
@@ -1,7 +1,7 @@
 Summary: Desktop manager for the XFce Desktop Environment
 Name: xfdesktop
 Version: 4.4.2
-Release: 3%{?dist}
+Release: 4%{?dist}
 License: GPLv2+
 URL: http://www.xfce.org/
 Source0: http://www.xfce.org/archive/xfce-4.4.2/src/xfdesktop-4.4.2.tar.bz2
@@ -12,6 +12,8 @@
 Patch1: xfdesktop-4.4.2-show-backdrop-by-default.patch
 # Fix for gcc 4.3
 Patch2: xfdesktop-4.4.2-gcc43.patch
+# Fix memory leaks
+Patch3: xfdesktop-4.4.2-memleak.patch
 
 Group: User Interface/Desktops
 BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
@@ -42,6 +44,7 @@
 %patch0 -p1 -b .fedora
 %patch1 -p1 -b .show-backdrop
 %patch2 -p1 -b .gcc43
+%patch3 -p1 -b .memleak
 
 %build
 %configure
@@ -87,6 +90,9 @@
 %{_mandir}/man1/*
 
 %changelog
+* Mon Aug 11 2008 Kevin Fenzi <kevin at tummy.com> - 4.4.2-4
+- Add partial memory leak patch (partially fixes #428662)
+
 * Tue Feb 19 2008 Kevin Fenzi <kevin at tummy.com> - 4.4.2-3
 - Rebuild for gcc43
 - Add patch for gcc43




More information about the fedora-extras-commits mailing list