rpms/e2fsprogs/F-8 e2fsprogs-1.40.7-lvm-libblkid-errcheck.patch, NONE, 1.1 e2fsprogs.spec, 1.87, 1.88
Eric Sandeen (sandeen)
fedora-extras-commits at redhat.com
Fri Feb 29 17:14:05 UTC 2008
- Previous message (by thread): rpms/gnome-web-photo/devel gnome-web-photo-0.3-libxul.patch, NONE, 1.1
- Next message (by thread): rpms/dxcc/devel dxcc-20071205-gui.patch, NONE, 1.1 dxcc-20071205-makefile.patch, NONE, 1.1 dxcc.desktop, NONE, 1.1 dxcc.png, NONE, 1.1 dxcc.spec, NONE, 1.1 .cvsignore, 1.1, 1.2 sources, 1.1, 1.2
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
Author: sandeen
Update of /cvs/pkgs/rpms/e2fsprogs/F-8
In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv2585
Modified Files:
e2fsprogs.spec
Added Files:
e2fsprogs-1.40.7-lvm-libblkid-errcheck.patch
Log Message:
* Thu Jan 31 2008 Eric Sandeen <esandeen at redhat.com> 1.40.4-2
- Handle lvm error conditions in libblkid (#433857) (from 1.40.7)
e2fsprogs-1.40.7-lvm-libblkid-errcheck.patch:
--- NEW FILE e2fsprogs-1.40.7-lvm-libblkid-errcheck.patch ---
From: Theodore Ts'o <tytso at mit.edu>
Date: Wed, 27 Feb 2008 03:24:42 +0000 (-0500)
Subject: libblkid: Add error checking to devicemapper code to avoid segfaults
X-Git-Tag: v1.40.7~18
X-Git-Url: http://git.kernel.org/?p=fs%2Fext2%2Fe2fsprogs.git;a=commitdiff_plain;h=1f1ee1948525632736e8135d797db116d2a34c8d
libblkid: Add error checking to devicemapper code to avoid segfaults
If a device mapper volume disappears while libblkid code is running,
it is possible for the devicemapper code to return errors, and since
libblkid wasn't checking for error returns, it would dereference a
null pointer and crash. Add error checking to prevent this.
Addresses-RedHat-Bugzilla: #433857
Signed-off-by: Eric Sandeen <sandeen at redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso at mit.edu>
---
diff --git a/lib/blkid/devname.c b/lib/blkid/devname.c
index fd64696..29cde8e 100644
--- a/lib/blkid/devname.c
+++ b/lib/blkid/devname.c
@@ -154,8 +154,10 @@ set_pri:
}
#ifdef HAVE_DEVMAPPER
-static void dm_quiet_log(int level, const char *file, int line,
- const char *f, ...)
+static void dm_quiet_log(int level __BLKID_ATTR((unused)),
+ const char *file __BLKID_ATTR((unused)),
+ int line __BLKID_ATTR((unused)),
+ const char *f __BLKID_ATTR((unused)), ...)
{
return;
}
@@ -168,38 +170,43 @@ static int dm_device_has_dep(const dev_t dev, const char *name)
struct dm_task *task;
struct dm_deps *deps;
struct dm_info info;
- int i;
+ unsigned int i;
+ int ret = 0;
task = dm_task_create(DM_DEVICE_DEPS);
if (!task)
- return 0;
+ goto out;
- dm_task_set_name(task, name);
- dm_task_run(task);
- dm_task_get_info(task, &info);
+ if (!dm_task_set_name(task, name))
+ goto out;
- if (!info.exists) {
- dm_task_destroy(task);
- return 0;
- }
+ if (!dm_task_run(task))
+ goto out;
+ if (!dm_task_get_info(task, &info))
+ goto out;
+
+ if (!info.exists)
+ goto out;
+
deps = dm_task_get_deps(task);
- if (!deps || deps->count == 0) {
- dm_task_destroy(task);
- return 0;
- }
+ if (!deps || deps->count == 0)
+ goto out;
for (i = 0; i < deps->count; i++) {
dev_t dep_dev = deps->device[i];
if (dev == dep_dev) {
- dm_task_destroy(task);
- return 1;
+ ret = 1;
+ goto out;
}
}
- dm_task_destroy(task);
- return 0;
+out:
+ if (task)
+ dm_task_destroy(task);
+
+ return ret;
}
static int dm_device_is_leaf(const dev_t dev)
@@ -212,19 +219,20 @@ static int dm_device_is_leaf(const dev_t dev)
dm_log_init(dm_quiet_log);
task = dm_task_create(DM_DEVICE_LIST);
if (!task)
- return 1;
+ goto out;
+
dm_log_init(0);
- dm_task_run(task);
+ if (!dm_task_run(task))
+ goto out;
+
names = dm_task_get_names(task);
- if (!names || !names->dev) {
- dm_task_destroy(task);
- return 1;
- }
+ if (!names || !names->dev)
+ goto out;
n = 0;
do {
- names = (void *)names + next;
+ names = (struct dm_names *) ((char *)names + next);
if (dm_device_has_dep(dev, names->name))
ret = 0;
@@ -232,7 +240,9 @@ static int dm_device_is_leaf(const dev_t dev)
next = names->next;
} while (next);
- dm_task_destroy(task);
+out:
+ if (task)
+ dm_task_destroy(task);
return ret;
}
@@ -245,20 +255,25 @@ static dev_t dm_get_devno(const char *name)
task = dm_task_create(DM_DEVICE_INFO);
if (!task)
- return ret;
+ goto out;
- dm_task_set_name(task, name);
- dm_task_run(task);
- dm_task_get_info(task, &info);
+ if (!dm_task_set_name(task, name))
+ goto out;
- if (!info.exists) {
- dm_task_destroy(task);
- return ret;
- }
+ if (!dm_task_run(task))
+ goto out;
+
+ if (!dm_task_get_info(task, &info))
+ goto out;
+
+ if (!info.exists)
+ goto out;
ret = makedev(info.major, info.minor);
- dm_task_destroy(task);
+out:
+ if (task)
+ dm_task_destroy(task);
return ret;
}
@@ -273,15 +288,15 @@ static void dm_probe_all(blkid_cache cache, int only_if_new)
dm_log_init(dm_quiet_log);
task = dm_task_create(DM_DEVICE_LIST);
if (!task)
- return;
+ goto out;
dm_log_init(0);
- dm_task_run(task);
+ if (!dm_task_run(task))
+ goto out;
+
names = dm_task_get_names(task);
- if (!names || !names->dev) {
- dm_task_destroy(task);
- return;
- }
+ if (!names || !names->dev)
+ goto out;
n = 0;
do {
@@ -289,7 +304,7 @@ static void dm_probe_all(blkid_cache cache, int only_if_new)
char *device = NULL;
dev_t dev = 0;
- names = (void *)names + next;
+ names = (struct dm_names *) ((char *)names + next);
rc = asprintf(&device, "mapper/%s", names->name);
if (rc < 0)
@@ -309,7 +324,9 @@ try_next:
next = names->next;
} while (next);
- dm_task_destroy(task);
+out:
+ if (task)
+ dm_task_destroy(task);
}
#endif /* HAVE_DEVMAPPER */
Index: e2fsprogs.spec
===================================================================
RCS file: /cvs/pkgs/rpms/e2fsprogs/F-8/e2fsprogs.spec,v
retrieving revision 1.87
retrieving revision 1.88
diff -u -r1.87 -r1.88
--- e2fsprogs.spec 31 Jan 2008 20:52:22 -0000 1.87
+++ e2fsprogs.spec 29 Feb 2008 17:13:31 -0000 1.88
@@ -4,7 +4,7 @@
Summary: Utilities for managing the second and third extended (ext2/ext3) filesystems
Name: e2fsprogs
Version: 1.40.4
-Release: 1%{?dist}
+Release: 2%{?dist}
# License based on upstream-modified COPYING file,
# which clearly states "V2" intent.
License: GPLv2
@@ -19,6 +19,7 @@
Patch4: e2fsprogs-1.40.4-uuidd-tidy.patch
Patch5: e2fsprogs-1.40.4-sb_feature_check_ignore.patch
Patch7: e2fsprogs-1.40.4-no-static-e2fsck.patch
+Patch8: e2fsprogs-1.40.7-lvm-libblkid-errcheck.patch
Url: http://e2fsprogs.sourceforge.net/
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
@@ -102,6 +103,8 @@
%patch5 -p1 -b .featurecheck
# completely clobber e2fsck.static build
%patch7 -p1 -b .e2fsck-static
+# lvm error handling in libblkid
+%patch8 -p1 -b .libblkid-lvmerrors
%build
aclocal
@@ -291,6 +294,9 @@
%dir %attr(2775, uuidd, uuidd) /var/lib/libuuid
%changelog
+* Thu Jan 31 2008 Eric Sandeen <esandeen at redhat.com> 1.40.4-2
+- Handle lvm error conditions in libblkid (#433857) (from 1.40.7)
+
* Thu Jan 31 2008 Eric Sandeen <esandeen at redhat.com> 1.40.4-1
- New upstream version, drop several now-upstream patches.
- New uuidd subpackage
- Previous message (by thread): rpms/gnome-web-photo/devel gnome-web-photo-0.3-libxul.patch, NONE, 1.1
- Next message (by thread): rpms/dxcc/devel dxcc-20071205-gui.patch, NONE, 1.1 dxcc-20071205-makefile.patch, NONE, 1.1 dxcc.desktop, NONE, 1.1 dxcc.png, NONE, 1.1 dxcc.spec, NONE, 1.1 .cvsignore, 1.1, 1.2 sources, 1.1, 1.2
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
More information about the fedora-extras-commits
mailing list