rpms/MAKEDEV/devel .cvsignore, 1.51, 1.52 MAKEDEV.spec, 1.59, 1.60 sources, 1.51, 1.52 makedev-3.23-compile-fix.patch, 1.1, NONE

[Christopher Edward Lumens (clumens)]

Author: clumens

Update of /cvs/pkgs/rpms/MAKEDEV/devel
In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv23578

Modified Files:
	.cvsignore MAKEDEV.spec sources 
Removed Files:
	makedev-3.23-compile-fix.patch 
Log Message:
New release.



Index: .cvsignore
===================================================================
RCS file: /cvs/pkgs/rpms/MAKEDEV/devel/.cvsignore,v
retrieving revision 1.51
retrieving revision 1.52
diff -u -r1.51 -r1.52
--- .cvsignore	20 Jun 2006 17:26:22 -0000	1.51
+++ .cvsignore	3 Mar 2008 16:17:51 -0000	1.52
@@ -1 +1,2 @@
 MAKEDEV-3.23-1.tar.gz
+MAKEDEV-3.23-4.tar.gz


Index: MAKEDEV.spec
===================================================================
RCS file: /cvs/pkgs/rpms/MAKEDEV/devel/MAKEDEV.spec,v
retrieving revision 1.59
retrieving revision 1.60
diff -u -r1.59 -r1.60
--- MAKEDEV.spec	25 Feb 2008 18:46:11 -0000	1.59
+++ MAKEDEV.spec	3 Mar 2008 16:17:51 -0000	1.60
@@ -1,15 +1,17 @@
 Name: MAKEDEV
 Version: 3.23
-Release: 3
+Release: 4
 Group: System Environment/Base
-License: GPL
-Source: MAKEDEV-%{version}-1.tar.gz
-Patch0: makedev-3.23-compile-fix.patch
-Summary: A program used for creating device files in /dev.
-BuildRoot: %{_tmppath}/%{name}-root
-BuildPrereq: libselinux-devel
+License: GPLv2
+# This is a Red Hat maintained package which is specific to
+# our distribution.  Thus the source is only available from
+# within this srpm.
+Source: MAKEDEV-%{version}-%{release}.tar.gz
+Summary: A program used for creating device files in /dev
+BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+BuildRequires: libselinux-devel
 URL: http://www.lanana.org/docs/device-list/
-Prereq: /usr/sbin/groupadd, /usr/sbin/useradd, grep, mktemp
+Requires(pre): shadow-utils
 
 %description
 This package contains the MAKEDEV program, which makes it easier to create
@@ -23,7 +25,6 @@
 
 %prep
 %setup -q
-%patch0 -p1
 
 %build
 make OPTFLAGS="$RPM_OPT_FLAGS" SELINUX=1
@@ -36,10 +37,11 @@
 rm -fr $RPM_BUILD_ROOT
 
 %pre
-# Add the floopy group and the vcsa user.
-/usr/sbin/groupadd -g 19 -r -f floppy > /dev/null 2>/dev/null
-/usr/sbin/useradd -c "virtual console memory owner" -u 69 \
-	-s /sbin/nologin -r -d /dev vcsa 2> /dev/null
+# Add the floppy group and the vcsa user.
+getent group floppy >/dev/null || groupadd -g 19 -r floppy
+getent passwd vcsa >/dev/null || \
+useradd -r -d /dev -s /sbin/nologin -u 69 \
+    -c "virtual console memory owner" vcsa
 exit 0
 
 %files
@@ -48,9 +50,22 @@
 %{_mandir}/man8/*
 %{_sbindir}/mksock
 /sbin/MAKEDEV
-%config %{_sysconfdir}/makedev.d
+%config(noreplace) %{_sysconfdir}/makedev.d
 
 %changelog
+* Mon Mar 03 2008 Chris Lumens <clumens at redhat.com> 3.23-4
+- Change license to GPLv2 only.
+- minor cleanups for merge review (Todd Zullinger <tmz at pobox.com>):
+  - rpmlint warnings fixed:
+    - buildprereq and prereq use
+    - quoted macros in %%changelog
+    - summary-ended-with-dot
+  - create vcsa user and floppy group according to packaging guidelines
+    (Packaging/UsersAndGroups)
+  - note that we are upstream for MAKEDEV above the source tag
+  - bring BuildRoot tag in line with the packaging guidelines
+  - remove grep and mktemp from Require
+
 * Mon Feb 25 2008 Jeremy Katz <katzj at redhat.com> - 3.23-3
 - Add fix to build with gcc 4.3
 
@@ -462,7 +477,7 @@
 - generate device manifest with MAKEDEV -M to build as non-root.
 
 * Wed Jul 11 2001 Bill Nottingham <notting at redhat.com>
-- add proper prereqs to dev package for %post (#48769)
+- add proper prereqs to dev package for %%post (#48769)
 
 * Thu Jul 05 2001 Florian La Roche <Florian.LaRoche at redhat.de>
 - disable unneeded parts of post for s390,s390x
@@ -491,7 +506,7 @@
 - add /dev/shm to fstab too
 
 * Thu Jun 22 2001 Nalin Dahyabhai <nalin at redhat.com>
-- own %{_sysconfdir}/makedev.d in addition to files it contains
+- own %%{_sysconfdir}/makedev.d in addition to files it contains
 
 * Wed Jun 21 2001 Karsten Hopp <karsten at redhat.de>
 - correct device naming and major/minor numbers on S390


Index: sources
===================================================================
RCS file: /cvs/pkgs/rpms/MAKEDEV/devel/sources,v
retrieving revision 1.51
retrieving revision 1.52
diff -u -r1.51 -r1.52
--- sources	20 Jun 2006 17:26:22 -0000	1.51
+++ sources	3 Mar 2008 16:17:51 -0000	1.52
@@ -1 +1 @@
-554faf6cbc9a84e4bd58ccfa32d74e2f  MAKEDEV-3.23-1.tar.gz
+362b9511f5bca9209cde450358384b1e  MAKEDEV-3.23-4.tar.gz


--- makedev-3.23-compile-fix.patch DELETED ---