rpms/kernel/F-8 linux-2.6-libata-sff-kill-spurious-WARN_ON-in-ata_hsm_move.patch, NONE, 1.1 kernel.spec, 1.536, 1.537

[Chuck Ebbert]

Author: cebbert

Update of /cvs/pkgs/rpms/kernel/F-8
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv23209

Modified Files:
	kernel.spec 
Added Files:
	linux-2.6-libata-sff-kill-spurious-WARN_ON-in-ata_hsm_move.patch 
Log Message:
libata-sff: kill spurious WARN_ON() in ata_hsm_move()
   Pointed-out-by: Arjan van de Ven (9c2676b61a5a4b6d99e65fb2f438fb3914302eda)

linux-2.6-libata-sff-kill-spurious-WARN_ON-in-ata_hsm_move.patch:

--- NEW FILE linux-2.6-libata-sff-kill-spurious-WARN_ON-in-ata_hsm_move.patch ---
>From 9c2676b61a5a4b6d99e65fb2f438fb3914302eda Mon Sep 17 00:00:00 2001
From: Tejun Heo <tj at kernel.org>
Date: Fri, 29 Aug 2008 16:27:43 +0200
Subject: [PATCH] libata-sff: kill spurious WARN_ON() in ata_hsm_move()

On HSM_ST_ERR, ata_hsm_move() triggers WARN_ON() if AC_ERR_DEV or
AC_ERR_HSM is not set.  PHY events may trigger HSM_ST_ERR with other
error codes and, with or without it, there just isn't much reason to
do WARN_ON() on it.  Even if error code is not set there, core EH
logic won't have any problem dealing with the error condition.

OSDL bz#11065 reports this problem.

Signed-off-by: Tejun Heo <tj at kernel.org>
Signed-off-by: Jeff Garzik <jgarzik at redhat.com>
---
 drivers/ata/libata-sff.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
index 304fdc6..2a4c516 100644
--- a/drivers/ata/libata-sff.c
+++ b/drivers/ata/libata-sff.c
@@ -1315,11 +1315,6 @@ fsm_start:
 		break;
 
 	case HSM_ST_ERR:
-		/* make sure qc->err_mask is available to
-		 * know what's wrong and recover
-		 */
-		WARN_ON(!(qc->err_mask & (AC_ERR_DEV | AC_ERR_HSM)));
-
 		ap->hsm_task_state = HSM_ST_IDLE;
 
 		/* complete taskfile transaction */
-- 
1.5.5.1



Index: kernel.spec
===================================================================
RCS file: /cvs/pkgs/rpms/kernel/F-8/kernel.spec,v
retrieving revision 1.536
retrieving revision 1.537
diff -u -r1.536 -r1.537
--- kernel.spec	19 Sep 2008 19:01:58 -0000	1.536
+++ kernel.spec	19 Sep 2008 21:58:04 -0000	1.537
@@ -651,6 +651,7 @@
 Patch675: linux-2.6-libata-pata_marvell-play-nice-with-ahci.patch
 Patch676: linux-2.6-libata-fix-a-large-collection-of-DMA-mode-mismatches.patch
 Patch677: linux-2.6-libata-lba-28-48-off-by-one-in-ata.h.patch
+Patch678: linux-2.6-libata-sff-kill-spurious-WARN_ON-in-ata_hsm_move.patch
 
 Patch680: linux-2.6-wireless.patch
 Patch681: linux-2.6-wireless-pending.patch
@@ -1181,6 +1182,8 @@
 ApplyPatch linux-2.6-libata-fix-a-large-collection-of-DMA-mode-mismatches.patch
 # libata breaks lba28 rules
 ApplyPatch linux-2.6-libata-lba-28-48-off-by-one-in-ata.h.patch
+# kill warn_on reported by kerneloops
+ApplyPatch linux-2.6-libata-sff-kill-spurious-WARN_ON-in-ata_hsm_move.patch
 
 # wireless
 #
@@ -1861,6 +1864,10 @@
 
 
 %changelog
+* Fri Sep 19 2008 Chuck Ebbert <cebbert at redhat.com> 2.6.26.5-27
+- libata-sff: kill spurious WARN_ON() in ata_hsm_move()
+   Pointed-out-by: Arjan van de Ven (9c2676b61a5a4b6d99e65fb2f438fb3914302eda)
+
 * Fri Sep 19 2008 Chuck Ebbert <cebbert at redhat.com> 2.6.26.5-26
 - wireless: rt2500pci: restoring missing line (from F9)