rpms/banshee/F-11 banshee-1.4.3-coverart_query.patch, NONE, 1.1 banshee.spec, 1.74, 1.75

[Tom Callaway]

Author: spot

Update of /cvs/pkgs/rpms/banshee/F-11
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv17738/F-11

Modified Files:
	banshee.spec 
Added Files:
	banshee-1.4.3-coverart_query.patch 
Log Message:
fix 492707

banshee-1.4.3-coverart_query.patch:

--- NEW FILE banshee-1.4.3-coverart_query.patch ---
# https://bugzilla.redhat.com/show_bug.cgi?id=492707
Index: src/Extensions/Banshee.CoverArt/Banshee.CoverArt/CoverArtJob.cs
===================================================================
--- src/Extensions/Banshee.CoverArt/Banshee.CoverArt/CoverArtJob.cs	(revision 4857)
+++ src/Extensions/Banshee.CoverArt/Banshee.CoverArt/CoverArtJob.cs	(working copy)
@@ -58,10 +58,12 @@
 
         private static HyenaSqliteCommand count_query = new HyenaSqliteCommand (@"
             SELECT count(DISTINCT CoreTracks.AlbumID)
-            FROM CoreTracks
+            FROM CoreTracks, CoreArtists, CoreAlbums
             WHERE
                 CoreTracks.PrimarySourceID = ? AND
                 CoreTracks.DateUpdatedStamp > ? AND
+                CoreTracks.AlbumID = CoreAlbums.AlbumID AND 
+                CoreAlbums.ArtistID = CoreArtists.ArtistID AND
                 CoreTracks.AlbumID NOT IN (
                     SELECT AlbumID FROM CoverArtDownloads WHERE
                         LastAttempt > ? OR Downloaded = 1)");


Index: banshee.spec
===================================================================
RCS file: /cvs/pkgs/rpms/banshee/F-11/banshee.spec,v
retrieving revision 1.74
retrieving revision 1.75
diff -u -r1.74 -r1.75
--- banshee.spec	6 Mar 2009 23:36:30 -0000	1.74
+++ banshee.spec	23 Apr 2009 22:08:06 -0000	1.75
@@ -2,7 +2,7 @@
 
 Name:    banshee
 Version: 1.4.3
-Release: 2%{?dist}
+Release: 3%{?dist}
 Summary: Easily import, manage, and play selections from your music collection
 Group:   Applications/Multimedia
 License: MIT
@@ -10,6 +10,7 @@
 Source0: http://banshee-project.org/files/banshee/banshee-1-%{version}.tar.bz2
 Source1: README.Fedora
 Patch0:  banshee-1.4.3-podcast_download.patch
+Patch1:  banshee-1.4.3-coverart_query.patch
 BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 
 # We only have mono on these arches:
@@ -112,7 +113,10 @@
 %prep
 %setup -q -n %{name}-1-%{version}
 cp -p %{SOURCE1} .
+# This only improves error handling for downloads
 %patch0 -p0 -b .patch
+# This fixes the 100% CPU usage bug while fetching cover art
+%patch1 -p0 -b .patch
 
 %build
 export MONO_SHARED_DIR=%mono_shared
@@ -197,6 +201,9 @@
 
 
 %changelog
+* Thu Apr 02 2009 David Nielsen <gnomeuser at gmail.com> - 1.4.3-3
+- add patch to fix rh#492707 - Banshee use 100% when fetching cover art
+
 * Sat Mar 07 2009 David Nielsen <dnielsen at fedoraproject.org> - 1.4.3-2
 - add patch for gnomebz #536047