rpms/system-config-kdump/devel system-config-kdump-1.0.14-off-by-one.patch, NONE, 1.1 system-config-kdump.spec, 1.6, 1.7

[Roman Rakus]

Author: rrakus

Update of /cvs/extras/rpms/system-config-kdump/devel
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv20006

Modified Files:
	system-config-kdump.spec 
Added Files:
	system-config-kdump-1.0.14-off-by-one.patch 
Log Message:
Fix off by one error in kernel command line parsing. Resolves #334269.

system-config-kdump-1.0.14-off-by-one.patch:

--- NEW FILE system-config-kdump-1.0.14-off-by-one.patch ---
diff -up system-config-kdump-1.0.14/src/system-config-kdump.py.off-by-one system-config-kdump-1.0.14/src/system-config-kdump.py
--- system-config-kdump-1.0.14/src/system-config-kdump.py.off-by-one	2009-03-23 14:13:11.000000000 +0100
+++ system-config-kdump-1.0.14/src/system-config-kdump.py	2009-03-23 14:13:44.000000000 +0100
@@ -213,7 +213,7 @@ class mainWindow:
                         tokens = crashString.split("@")
                         kdumpMemGrubby = int(tokens[0][:-1])
                         if len(tokens) == 2:
-                            kdumpOffsetGrubby = int(tokens[2][:-1])
+                            kdumpOffsetGrubby = int(tokens[1][:-1])
 			if debug:
 				print "grubby --info: crashkernel=%iM@%iM" \
 					% (kdumpMemGrubby, kdumpOffsetGrubby)


Index: system-config-kdump.spec
===================================================================
RCS file: /cvs/extras/rpms/system-config-kdump/devel/system-config-kdump.spec,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- system-config-kdump.spec	26 Feb 2009 05:06:01 -0000	1.6
+++ system-config-kdump.spec	23 Mar 2009 13:18:31 -0000	1.7
@@ -1,7 +1,7 @@
 Summary: A graphical interface for configuring kernel crash dumping
 Name: system-config-kdump
 Version: 1.0.14
-Release: 4%{?dist}
+Release: 5%{?dist}
 URL: http://fedora.redhat.com/projects/config-tools/
 License: GPLv2+
 Group: System Environment/Base
@@ -21,6 +21,7 @@
 Patch1: s-c-kdump-1.0.14-reflect-current-settings.patch
 Patch2: system-config-kdump-1.0.14-fedora.patch
 Patch3: system-config-kdump-1.0.14-ommit-offset.patch
+Patch4: system-config-kdump-1.0.14-off-by-one.patch
 
 %description
 system-config-kdump is a graphical tool for configuring kernel crash
@@ -31,6 +32,7 @@
 %patch1 -p1 -b .reflect
 %patch2 -p1 -b .fedora
 %patch3 -p1 -b .ommit-offset
+%patch4 -p1 -b .off-by-one
 %build
 make
 
@@ -74,6 +76,10 @@
 %doc ChangeLog COPYING
 
 %changelog
+* Mon Mar 23 2009 Roman Rakus <rrakus at redhat.com> - 1.0.14-5
+- Fix off by one error in kernel command line parsing
+  Resolves #334269
+
 * Wed Feb 25 2009 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 1.0.14-4
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_11_Mass_Rebuild