Candidate for Extras: evolution-groupdav (Noodle project connector for OpenGroupware)

[Nils Philippsen]

On Wed, 2005-03-30 at 21:22 -0500, David Malcolm wrote:
> I had a go at packaging the Noodle projects's connector for Evolution
> for OoenGroupware, you can see the results here:
> 
> http://people.redhat.com/dmalcolm/noodle/
> 
> Would this be a good candidate for Extras?

I'd say yes. I took the "quick tour", i.e. looked at the spec file only
(not having OGO installed):

- I'm not sure about this one:

[...]
%define blabla_version 0.5
[...]
Requires: blabla >= %blabla_version
[...]
BuildRequires: blabla-devel >= %blabla_version
[...]

Ideally I'd rather only "BuildRequires: blabla-devel >= 0.5" and let
automatic dependency tracking sort out the rest. If that isn't
sufficient, I guess this should be solved in rpmbuild and not the spec
files (only MO). Probably "Requires: evolution-data-server ..." rather
than "Requires: evolution-data-server-devel ... " if you really
must ;-), the same goes for libgnomeui.
- Some people are more comfy with
  "BuildRoot: %{_tmppath}/%{name}-%{version}-root-%(%__id_u -n)"
- Maybe "Source: evolution-groupdav-%{version}.tar.gz" -->
"Source0: http://noodle.yacoi.com/devel/downloads/evolution-groupdav/evolution-groupdav-%{version}.tar.gz"
- Cosmetics: Make %description a whole sentence, e.g. "Evolution-
groupdav contains a plugin and backends...."
- You should run "make" in %build, not only "make DESTDIR=... install"
in %install (then use %makeinstall if possible)
- Don't "[ -n "$RPM_BUILD_ROOT" -a "$RPM_BUILD_ROOT" != / ] && rm -rf
$RPM_BUILD_ROOT", just "rm -rf $RPM_BUILD_ROOT" (or even "rm -rf %
buildroot", what suits you better), rpmbuild will take care of that 
%buildroot/$RPM_BUILD_ROOT isn't "/"
- "BuildRequires: findutils" if you use the find command

HTH,
Nils
-- 
     Nils Philippsen    /    Red Hat    /    nphilipp at redhat.com
"They that can give up essential liberty to obtain a little temporary
 safety deserve neither liberty nor safety."     -- B. Franklin, 1759
 PGP fingerprint:  C4A8 9474 5C4C ADE3 2B8F  656D 47D8 9B65 6951 3011