[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Review: Comical



On Sun, 2005-04-03 at 22:25 -0500, Tom 'spot' Callaway wrote:
> Please review this package for FE. I'm willing to submit and maintain
> it.
> 
> Description:
> Comical is a fully featured GUI comic book viewer using wxWindows. It
> can view CBZ format files. (CBR format files are viewable if unrar is
> present).
> 
> URL: http://comical.sourceforge.net/
> 
> The package and the spec file can be found here:
> http://people.redhat.com/tcallawa/comical/
> 

The spec looks fine.  Though, you might want to add this patch to
correct errors if the archives contains images with '[' or ']' in the
filename.  Back when I looked at it, a bunch of users had problems with
crashing while opening archives.

/B
-- 
Brian Pepple <bdpepple ameritech net>

gpg --keyserver pgp.mit.edu --recv-keys 810CC15E
BD5E 6F9E 8688 E668 8F5B  CBDE 326A E936 810C C15E
diff -Naur comical-0.4-orig/ChangeLog comical-0.4/ChangeLog
--- comical-0.4-orig/ChangeLog	2004-01-21 14:49:10.000000000 -0500
+++ comical-0.4/ChangeLog	2004-12-22 05:49:15.139093484 -0500
@@ -1,3 +1,7 @@
+0.4.1 - Patch by John McAree (john mcaree org)
+Fixed bug in which an archive containing images with '[' or ']'
+would cause the archive to fail to load
+
 0.4 -
 Added support for bzip2 archives, with extension .bz2 or .cbb
 Added more sensical keyboard shortcuts
diff -Naur comical-0.4-orig/src/ComicBookBZ2.cpp comical-0.4/src/ComicBookBZ2.cpp
--- comical-0.4-orig/src/ComicBookBZ2.cpp	2004-01-21 04:30:35.000000000 -0500
+++ comical-0.4/src/ComicBookBZ2.cpp	2004-12-22 05:49:58.793190008 -0500
@@ -67,6 +67,8 @@
   {
     wxLogVerbose("Contents of %s:", filename.c_str());
     for (i = 0; i < entries.size(); i++) {
+      entries[i].Replace("[", "\\[");
+      entries[i].Replace("]", "\\]");
       wxLogVerbose("smushed entry %i : %s", i, entries[i].c_str());
       wxStringTokenizer tokens(entries[i], "\t");
       pages.push_back(tokens.GetNextToken());
diff -Naur comical-0.4-orig/src/ComicBookRAR.cpp comical-0.4/src/ComicBookRAR.cpp
--- comical-0.4-orig/src/ComicBookRAR.cpp	2004-01-21 16:08:16.000000000 -0500
+++ comical-0.4/src/ComicBookRAR.cpp	2004-12-22 05:49:58.824185106 -0500
@@ -69,6 +69,8 @@
   {
     wxLogVerbose("Contents of %s:", filename.c_str());
     for (i = 0; i < entries.size(); i++) {
+      entries[i].Replace("[", "\\[");
+      entries[i].Replace("]", "\\]");
       wxLogVerbose("smushed entry %i : %s", i, entries[i].c_str());
       wxStringTokenizer tokens(entries[i], "\t");
       pages.push_back(tokens.GetNextToken());
diff -Naur comical-0.4-orig/src/ComicBookZIP.cpp comical-0.4/src/ComicBookZIP.cpp
--- comical-0.4-orig/src/ComicBookZIP.cpp	2004-01-21 04:30:35.000000000 -0500
+++ comical-0.4/src/ComicBookZIP.cpp	2004-12-22 05:49:58.854180362 -0500
@@ -61,6 +61,8 @@
   {
     wxLogVerbose("Contents of %s:", filename.c_str());
     for (i = 0; i < entries.size(); i++) {
+      entries[i].Replace("[", "\\[");
+      entries[i].Replace("]", "\\]");
       wxLogVerbose("smushed entry %i : %s", i, entries[i].c_str());
       wxStringTokenizer tokens(entries[i], "\t");
       pages.push_back(tokens.GetNextToken());

Attachment: signature.asc
Description: This is a digitally signed message part


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]