[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: rpms/bzflag/devel bzflag.spec,1.7,1.8



On Wed, 2005-04-06 at 16:22 +0200, Ralf Corsepius wrote:
> On Wed, 2005-04-06 at 09:27 -0400, Nils Philippsen wrote:
> > Author: nphilipp
> > 
> > Update of /cvs/extras/rpms/bzflag/devel
> > In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv31395
> > 
> > Modified Files:
> > 	bzflag.spec 
> > Log Message:
> > build with adns
> > build require minimum version of xorg-x11-devel to hopefully solve the GL building problems
> > 
> > 
> > 
> > Index: bzflag.spec
> > ===================================================================
> > RCS file: /cvs/extras/rpms/bzflag/devel/bzflag.spec,v
> > retrieving revision 1.7
> > retrieving revision 1.8
> > diff -u -r1.7 -r1.8
> > --- bzflag.spec	30 Mar 2005 15:01:06 -0000	1.7
> > +++ bzflag.spec	6 Apr 2005 13:27:54 -0000	1.8
> > @@ -11,14 +11,13 @@
> >  Source: http://ftp.bzflag.org/bzflag/bzflag-%{version}%{?date:.%{date}}.tar.bz2
> >  Source1: bzflag.desktop
> >  BuildRoot: %{_tmppath}/%{name}-%{version}-root-%(%{__id_u} -n)
> > -BuildRequires: xorg-x11-devel
> > -# work around missing dependency in xorg-x11-devel:
> > -BuildRequires: libGL.so.1 libGLU.so.1
> > +BuildRequires: xorg-x11-devel >= 6.8.2-14
> 
> Veto.

I don't think there is such a thing as a formal(ized?) veto of a
specific commit (of a package that is already in Extras that is, anybody
please correct me if I'm wrong here).

Besides, out of common courtesy you could have used different phrasing
-- "use BuildRequires: xorg-x11-devel libGL-devel libGLU-devel instead"
sounds so much more helpful, don't you think?

> > +- build require minimum version of xorg-x11-devel to hopefully solve
> > the GL  building problems
> 
> AFAIS, you have just removed GL entirely.

You don't seem to have looked at the changes in xorg-x11-devel >=
6.8.2-14. While the build requirement above isn't formally correct, it
would work at the moment. I'll commit appropriate changes momentarily.

Nils
-- 
     Nils Philippsen    /    Red Hat    /    nphilipp redhat com
"They that can give up essential liberty to obtain a little temporary
 safety deserve neither liberty nor safety."     -- B. Franklin, 1759
 PGP fingerprint:  C4A8 9474 5C4C ADE3 2B8F  656D 47D8 9B65 6951 3011


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]