[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Request for Review: bioperl and its dependancies



Hunter,

A couple of notes about the specfiles:

* License

  Most of the license information appears to be incomplete.
  If the copyright section says that the module is available
  on the same terms as perl itself, the license is "GPL or
  Artistic".

  License: GPL or Artistic

* URL

  If the module is available in CPAN don't use a URL
  that contains the author id and the module version.

  Example:
  Use
    http://search.cpan.org/dist/Heap/
  instead of
    http://search.cpan.org/~jmm/Heap-0.70/

  By the way you need to update Heap to version 0.71.

* Source tarball URL

  If the module is available in CPAN there is a shorter URL.

  Example:
  use
  http://www.cpan.org/authors/id/J/JM/JMM/Heap-0.70.tar.gz
  instead
  http://search.cpan.org/CPAN/authors/id/J/JM/JMM/Heap-0.70.tar.gz


* %build section

  When a module is noarch you can drop CFLAGS and OPTIMIZE.


Will try to give a second look later (I still haven't built the RPMS).
(I wish we had a Bugzilla for QA).

Regards,
jpo
-- 
José Pedro Oliveira
* mailto: jpo di uminho pt * http://gsd.di.uminho.pt/~jpo *
* gpg fingerprint = F9B6 8D87 859D 1C94 48F0 84C0 9749 9EB5 91BD 851B *

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]