[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Review needed: notecase



Another patch:
%changelog
* Wed Apr 6 2005 Toshio Kuratomi <toshio-tiki-lounge.com> 0.8.2-4
- Eliminate dos2unix warning by only running on regular files.
- Substitute paths in config.h from rpm macros.

The first part is trivial.  The second part is necessary in order to get
help to work.

The rest of my notes are at your discretion:
* Notemeister is very similar to Notecase and its group is
Applications/Productivity.  Since Notecase describes itself as an
"outliner" I think that would be a more appropriate Group.

* Except for prefix, paths in Notecase's build are hardcoded into the
Makefile.  For example:
  install -D -m 644 docs/notecase.desktop \
    "$(prefix)/share/applications/notecase.desktop"%{

This means %{_bindir}, %{_datadir}, and similar path macros aren't
having an effect on where files are installed.  So for now, the macros
in the %files section and where the files actually end up matches -- but
they won't if future versions of Fedora or Notecase change the positions
of these directories independently.  You may want to note that in the
spec or patch the Makefile and submit upstream.

This is the reason the second item in my patch operates on both
directories listed in config.h even though only one prevents normal
operation of the program.  

-Toshio
-- 
toshio \ Questions for the            Would Morticia wear it?
 @tiki- \ 21st Century!               Would it look better on me?
 lounge.com=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~
                                                                GA->ME 1999
Index: notecase.spec
===================================================================
RCS file: /cvs/extras/devel/notecase/notecase.spec,v
retrieving revision 1.3
diff -u -u -r1.3 notecase.spec
--- notecase.spec	5 Apr 2005 10:21:12 -0000	1.3
+++ notecase.spec	6 Apr 2005 18:52:41 -0000
@@ -1,6 +1,6 @@
 Name:           notecase
 Version:        0.8.2
-Release:        3
+Release:        4
 Summary:        A hierarchical note manager
 
 Group:          Applications/Text
@@ -24,9 +24,15 @@
 %prep
 %setup -q -n notecase
 %patch -p1
-find docs -exec /usr/bin/dos2unix \{\} \;
+find docs -type f -exec /usr/bin/dos2unix \{\} \;
 /usr/bin/dos2unix readme.txt
 
+sed 's!\(#define HELP_FILE_PATH\).*!\1 "%{_docdir}/%{name}-%{version}/help.ncd"!' \
+  < src/config.h > config.h.tmp
+sed 's!\(#define LOCALE_DIR\).*!\1 "%{_datadir}/locale/"!' \
+  < config.h.tmp > src/config.h
+rm -f config.h.tmp
+
 %build
 make CFLAGS="$RPM_OPT_FLAGS" %{?_smp_mflags}
 
@@ -62,6 +68,10 @@
 %{_datadir}/mime/packages/%{name}.xml
 
 %changelog
+* Wed Apr 6 2005 Toshio Kuratomi <toshio tiki-lounge com> 0.8.2-4
+- Eliminate dos2unix warning by only running on regular files.
+- Substitute paths in config.h from rpm macros.
+  
 * Tue Apr  5 2005 Ignacio Vazquez-Abrams <ivazquez ivazquez net> 0.8.2-3
 - Use dos2unix instead of sed
 

Attachment: signature.asc
Description: This is a digitally signed message part


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]