Review needed: notecase

Michael Schwendt bugs.michael at gmx.net
Wed Apr 13 21:45:15 UTC 2005


On Wed, 13 Apr 2005 16:37:47 -0400, Toshio wrote:

> On Wed, 2005-04-13 at 19:16 +0200, Michael Schwendt wrote:
> > On Wed, 13 Apr 2005 09:52:23 -0400, Toshio wrote:
> > 
> > > 2) Old recommendation to not mix %patch with %patchN (ie: use Patch0:
> > > notecase-.... %patch0 -p1  Instead of Patch: notecase-... %patch -p1)
> > 
> > What's the background for this recommendation?
> > 
> > What's an example for "problems" caused by mixing %patch with %patchN?
> > 
> Disclaimer: I didn't make this a prereq for approval, just noted it.
> (Unlike #1 which could affect end-user's menus.)
> 
> It's on the wiki at: http://www.fedoraproject.org/wiki/NewPackageProcess
> 
> There was some discussion on packaging-list about justification of which
> this one stuck in my mind:
> https://www.redhat.com/archives/fedora-packaging/2005-March/msg00045.html

Oh, I even participated in that thread. ;)

Okay, okay, so it's just stylistic nitpicking and requires packagers to
change something into something else which doesn't improve the package.
I think we've yet to see a package where somebody really tries

  Patch: foo.patch
  Patch: bar.patch

  %patch -b .foo
  %patch -b .bar

and actually manages to testbuild it.




More information about the fedora-extras-list mailing list