Request for Review: bmp-flac
Michael Schwendt
bugs.michael at gmx.net
Tue Apr 19 13:17:30 UTC 2005
On Tue, 19 Apr 2005 14:56:08 +0200, Ralf Ertzinger wrote:
> Hi.
>
> I have a quite simple initial version of a bmp-flac package ready
> for inclusion.
>
> Package and specfile at http://ryoko.camperquake.de/fedora/bmp-flac/
* There should be no need to hardcode the BMP input plugin path in
the Makefile and the spec. Use this instead (and a similar thing in the
Makefile):
%define plugindir %(pkg-config bmp --variable=input_plugin_dir)
and
%{plugindir}/libflac.so
in the %files section. That also avoids multilib problems.
* $RPM_OPT_FLAGS are not accepted. You need to pass CFLAGS= to "make"
manually.
More information about the fedora-extras-list
mailing list