[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Request for review (again?): quilt



On Fri, 2005-04-22 at 07:02 -0400, Toshio wrote:
> On Thu, 2005-04-21 at 18:14 -0500, Josh Boyer wrote:
> > On Thu, 2005-04-21 at 18:03 -0400, Toshio wrote:
> > > On Wed, 2005-04-20 at 19:36 -0500, Josh Boyer wrote:
> > > > Hi,
> > > > 
> > > > I've imported the quilt package into CVS now.  It's already gone through
> > > > a review from a couple of folks a while back, but I thought I would post
> > > > another review just to be sure I followed the process.
> > > > 
> > > Things look pretty good.  The imported sources closely mirror what was
> > > reviewed.  One question, though -- why was the Requires: rpm-build
> > > removed?  Was it because `quilt setup` functionality wasn't deemed
> > > necessary or because rpm-build is always supposed to be installed?
> > 
> > The latter.  I can add it back in and get rid of some of the other
> > Requires: that it depends on if you'd like.  That does make sense.
> > 
> > Ok, I've made that change and checked it into CVS.  Any other comments
> > from anyone?
> 
> Changes look good.  If you don't have someone else to sponsor the
> package, feel free to use me when you post APPROVED.

Thanks.  I know Warren had a comment on the Requires, but he hasn't
found the time to respond yet.  It was minor, so in the interest of
getting the build going, I'll call it approved.

As always, comments are still welcome.

thx,
josh


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]