[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Request for Review - PyRTF



On Wed, 2005-04-13 at 14:15 -0400, Ignacio Vazquez-Abrams wrote:
> On Wed, 2005-04-13 at 10:35 -0700, Michael Peters wrote:
> > On Wed, 2005-04-13 at 05:33 -0400, Ignacio Vazquez-Abrams wrote:
> > > On Wed, 2005-04-13 at 02:14 -0700, Michael Peters wrote:
> > > > My spec file - http://mpeters.us/fc_extras/PyRTF.spec
> > > 
> > > ? Source0 should have a complete URL if possible (e.g.,
> > > http://prdownloads.sourceforge.net/pyrtf/PyRTF-0.43.tar.gz)
> > > - BR should be python, not python-devel
> > > - Dir %{python_sitelib}/PyRTF not owned by package
> > > - Should have [E:]V-R on every changelog entry
> > 
> > Thanks - fixed
> 
> You missed the BR. noarch Python packages only need distutils, not the
> whole includes/libs set. And distutils comes in the base python package.

New specfile, upstream fixed the locale stuff so I don't have to patch
that anymore, I also (after reading through wiki) changed the Source0 to
not use macros so that testers can wget cut-n-paste to verify package.

-=-

New files:

http://mpeters.us/fc_extras/gourmet.spec
http://mpeters.us/fc_extras/gourmet-0.8.3.4-1.src.rpm
http://mpeters.us/fc_extras/gourmet-0.8.3.4.desktop.patch

The dependency not in core/extras (PyRTF) is another package I've asked
for review elsewhere.

Yes - I neglected BuildRequires for desktop-file-install.
That will be fixed with next upload.

With next upload I also will change the desktop.patch to not modify the
setup.py script, and instead %ghost the desktop file it installs (but
patch still needed for the desktop file itself)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]