[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Review Request: NCO and CDO



On Fri, 2005-04-22 at 10:40 -0400, Ed Hill wrote:
> Hi folks (with a special plea to Spot!),
> 
> I'd like to humbly request reviews of NCO and CDO.  The former made it
> part-way through the "old" Fedora review process:
> 
>   https://bugzilla.fedora.us/show_bug.cgi?id=1893
> 
> and has been updated to fix (hopefully) all the outstanding problems
> from that earlier submission.

It does look like the outstanding problems from the b.f.u ticket have
been resolved.

A couple of items I found:

+BuildRequires:  udunits, udunits-devel
+BuildRequires:  curl-devel, libxml2-devel, opendap-devel, librx-devel

You're missing some BuildRequires. (Note that opendap-devel and
librx-devel are pending sponsorship and review.)

-export CXXFLAGS='-fpermissive'
+export CXXFLAGS="$RPM_OPT_FLAGS -fpermissive"

No reason I can see to drop the optimization flags entirely, it builds
great with them in rawhide.

You also need to apply one more package for udunits to work properly.
This patch is attached to the email.

~spot
-- 
Tom "spot" Callaway: Red Hat Sales Engineer || GPG Fingerprint: 93054260
Fedora Extras Steering Committee Member (RPM Standards and Practices)
Aurora Linux Project Leader: http://auroralinux.org
Lemurs, llamas, and sparcs, oh my!
--- nco-3.0.0/configure.in.BAD	2005-04-22 10:53:36.000000000 -0500
+++ nco-3.0.0/configure.in	2005-04-22 10:53:54.000000000 -0500
@@ -408,10 +408,8 @@
     LDFLAGS="${LDFLAGS} -L${UDUNITS_PATH}/lib"
     CPPFLAGS="${CPPFLAGS} -I${UDUNITS_PATH}/include"
 #    nco_udunits_dat=${UDUNITS_PATH}/src/lib/udunits.dat
-  elif test "${NETCDF_INC}"; then
-    nco_udunits_dat="${NETCDF_INC}/../etc/udunits.dat"
   else
-    nco_udunits_dat="/usr/local/etc/udunits.dat"
+    nco_udunits_dat="/etc/udunits.dat"
   fi
 # warn if udunits.dat is not found, but continue anyway since the builder may savy and know to add it later, like when building packages (e.g. .debs)
   AC_CHECK_FILE([$nco_udunits_dat],,AC_WARN([file $nco_udunits_dat was not found but will be compiled into NCO. Some executables may fail without it.]))

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]