[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Sponsor and review request: opendap, librx



On Sat, 23 Apr 2005 10:05:30 -0500, Tom 'spot' Callaway wrote:

> opendap:
> OPeNDAP provides software which makes local data accessible to remote
> locations regardless of local storage format. OPeNDAP also provides
> tools for transforming existing applications into OPeNDAP clients (i.e.,
> enabling them to remotely access OPeNDAP served data). OPeNDAP software
> is freely available.
> 
> URL: http://www.opendap.org/
> SRPM:http://www.auroralinux.org/people/spot/review/opendap-3.4.4-1.src.rpm
> SPEC: http://www.auroralinux.org/people/spot/review/opendap.spec
> 
> Please help me sponsor and review these packages, so I can sponsor and
> review NCO. ;)


> BuildRequires:  openssl, pkgconfig
> BuildRequires:  curl, krb5-libs

Please double-check whether this should be

BuildRequires: openssl-devel curl-devel pkgconfig


> %install
> rm -rf ${RPM_BUILD_ROOT}
> cd DODS/
> # move the docs to the toplevel
> mv ChangeLog INSTALL NEWS VERSION README ../

Not a blocker, since you're going to maintain this. But *please* try
not to break --short-circuit rpmbuild installs as they are really very
useful for debugging %install/%files sections. As a rule of thumb,
don't move/delete files below $RPM_BUILD_DIR. Where needed, copy
files to temporary directories. But don't delete or move them.

> %post devel
> /sbin/ldconfig
>
> %postun devel
> /sbin/ldconfig

Missing dependencies on /sbin/ldconfig then, which is unlikely to not
be installed already. But well...


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]