[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Sponsor and review request: opendap, librx

On Sat, 2005-04-23 at 21:29 +0200, Michael Schwendt wrote:

> Please double-check whether this should be
> BuildRequires: openssl-devel curl-devel pkgconfig

Yeah, it should be. (with krb5-libs too)

> > %install
> > rm -rf ${RPM_BUILD_ROOT}
> > cd DODS/
> > # move the docs to the toplevel
> Not a blocker, since you're going to maintain this. But *please* try
> not to break --short-circuit rpmbuild installs as they are really very
> useful for debugging %install/%files sections. As a rule of thumb,
> don't move/delete files below $RPM_BUILD_DIR. Where needed, copy
> files to temporary directories. But don't delete or move them.

I did this to make the copying easier (since this application set
doesn't have any concept of "make install"), but now that I'm cutting
out all the "included" packages that it was using (its own copy of zlib,
curl, libxml2), its as easy (easier even) to not do it like this.

> > %post devel
> > /sbin/ldconfig
> >
> > %postun devel
> > /sbin/ldconfig
> Missing dependencies on /sbin/ldconfig then, which is unlikely to not
> be installed already. But well...

Good point. I'll -p those.

New opendap packages (much smaller, much faster to build) which
incorporate all of Ed's and Michael's suggestions:
SPEC: http://www.auroralinux.org/people/spot/review/opendap.spec

Please sponsor or point out blockers. :)


Tom "spot" Callaway: Red Hat Sales Engineer || GPG Fingerprint: 93054260
Fedora Extras Steering Committee Member (RPM Standards and Practices)
Aurora Linux Project Leader: http://auroralinux.org
Lemurs, llamas, and sparcs, oh my!

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]