[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: sponsor and review request: rzip

On Sun, Apr 24, 2005 at 02:07:20PM +0400, Paul P Komkoff Jr wrote:
> rzip is a compression program written by Andrew Tridgell.
> More information is available at http://rzip.samba.org/
> SRPM available at http://gw6.sgu.ru/st/SRPMS/rzip-2.0-1.src.rpm

You shouldn't specify $RPM_BUILD_ROOT during %build. Although the path
doesn't seem to be anywhere in the built package following patch
should be applied:

--- rzip.spec   2005-04-24 11:17:49.000000000 +0200
+++ /tmp/rzip.spec      2005-04-24 12:25:56.000000000 +0200
@@ -20,13 +20,13 @@
-%configure --prefix=$RPM_BUILD_ROOT/usr/share --exec-prefix=$RPM_BUILD_ROOT/usr
 make %{?_smp_mflags}
-make install
+make install INSTALL_BIN=$RPM_BUILD_ROOT%{_bindir} INSTALL_MAN=$RPM_BUILD_ROOT%{_mandir}

Maybe you could also change the summary from: 

Summary:        A tridge file compression utility

to the one specified in the man page:

Summary:        A large-file compression program

And a %doc section would be nice even if it only includes the COPYING


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]