use of gtk-update-icon-cache?

[Thorsten Leemhuis]

I planed this mail for the weekend after a bit more investigation in
this area, but while on topic I better start now:

Am Freitag, den 29.04.2005, 11:36 +0200 schrieb F. Kooman:

> %post
> # update icon themes
> touch %{_datadir}/icons/hicolor
> if [ -x /usr/bin/gtk-update-icon-cache ]; then
>   /usr/bin/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor
> fi

AFAIK we also need to do this in %post and %postun in every FC4/devel
extras-package that installs something into "%{_datadir}/icons/*/" so
the cache files found there. After a quick rough look into cvs it seems
at least this packages need the patch found below:

abiword
amarok
clearlooks
djvulibre
enigma
fyre
gnome-themes-extras
gwenview
kid3
kile
kover
ksensors
ktrack
libkipi
notecase
psi
revelation
showimg
TeXmacs
tuxpaint
xcin
xfcalendar
xfce4-iconbox
xfce4-mixer
xfce4-panel
xfce4-session
xfce-mcs-manager
xfce-utils
xfdesktop
xffm
xfprint
xfwm4

Proposed patch (this one against revelation/devel)

##########################
Index: revelation.spec
===================================================================
RCS file: /cvs/extras/rpms/revelation/devel/revelation.spec,v
retrieving revision 1.8
diff -u -r1.8 revelation.spec
--- revelation.spec     2 Apr 2005 11:32:55 -0000       1.8
+++ revelation.spec     29 Apr 2005 10:01:34 -0000
@@ -4,7 +4,7 @@
 Summary:       Password manager for GNOME 2
 Name:          revelation
 Version:       0.4.3
-Release:       2
+Release:       3
 License:       GPL
 Group:         Applications/Productivity
 Source:                ftp://oss.codepoet.no/revelation/revelation-0.4.3.tar.bz2
@@ -26,9 +26,11 @@
 BuildRequires: cracklib
 BuildRequires: words
 BuildRoot:     %{_tmppath}/%{name}-%{version}-buildroot-%(%{__id_u} -n)
-Requires(post):                GConf2 shared-mime-info desktop-file-utils
-Requires(preun):       GConf2
+Requires(post):                GConf2 shared-mime-info desktop-file-utils
+Requires(post):                gtk2 >= 2.6
+Requires(preun):       GConf2
 Requires(postun):      shared-mime-info desktop-file-utils
+Requires(postun):      gtk2 >= 2.6

 %description
 Revelation is a password manager. It organizes accounts in
@@ -60,7 +62,10 @@
 gconftool-2 --makefile-install-rule %{_sysconfdir}/gconf/schemas/%{name}.schemas &>/dev/null || :
 update-mime-database %{_datadir}/mime > /dev/null 2>&1 || :
 update-desktop-database %{_datadir}/applications > /dev/null 2>&1 || :
-
+touch --no-create %{_datadir}/icons/hicolor || :
+if [ -x /usr/bin/gtk-update-icon-cache ]; then
+  gtk-update-icon-cache -q %{_datadir}/icons/hicolor || :
+fi

 %preun
 export GCONF_CONFIG_SOURCE=`gconftool-2 --get-default-source`
@@ -69,7 +74,10 @@
 %postun
 update-mime-database %{_datadir}/mime > /dev/null 2>&1 || :
 update-desktop-database %{_datadir}/applications > /dev/null 2>&1 || :
-
+touch --no-create %{_datadir}/icons/hicolor  || :
+if [ -x /usr/bin/gtk-update-icon-cache ]; then
+  gtk-update-icon-cache -q %{_datadir}/icons/hicolor || :
+fi

 %clean
 %{__rm} -rf %{buildroot}
@@ -101,6 +109,9 @@
 %ghost %{python_sitelib}/revelation/datahandler/*.pyo

 %changelog
+* Wed Apr 27 2005 Thorsten Leemhuis <fedora at leemhuis dot info> 0.4.3-3
+- Update the GTK+ theme icon cache on (un)install
+
 * Sat Apr 02 2005 Thorsten Leemhuis <fedora at leemhuis dot info> 0:0.4.3-2
 - Devel rebuild

##########################

Any comments on that patch?

CU
thl