[Bug 165963] Review Request: libnet. Packet construction and injection library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libnet. Packet construction and injection library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165963





------- Additional Comments From oliver at linux-kernel.at  2005-08-26 06:50 EST -------
(In reply to comment #9)
> I have some comments about your patch
> 
> * you shouldn't use perl but sed

I'm a perl-fan :-) But of course sed would be better...

> * is the doxygen.conf file really needed?

No it is not - you're correct.

> I used pushd/popd from your patch.

Fine.

> Otherwise I guess the dynamic libraries and installation cleanups are only in
> 1.1.3. 

Yes, they are only in 1.1.3, but I hope/guess 1.1.3 will come out soon. You can
also think about building the RC 1.1.3 for -devel only...

> (and I think unified diffs are more handy, I couldn't apply yours)

Next time... :-)

-of

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.