make check in libcdio

[Warren Togami]

Adrian Reber wrote:
>  know that a 'make check' which does network tests is not allowed in
> a spec file, but what about a 'make check' which tries to access the
> CDROM?
> 
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=164266
> 
> libcdio does about 13 tests during 'make check' and one test is using a
> CD if it can find one in the drive. So should this 'make check' also be
> disabled? If there is no CD in the drive nothing happens, but if there
> is a CD in the drive the check tries to access it.
> Is a test trying to access the hardware of the buildsystem as bad as a
> test trying to access the network?

I haven't looked in mock's code recently, but last I checked mock only 
populates a very minimal set of /dev nodes within the buildroot.  Among 
those included are not any block devices, so it sounds like your 
specific case wont affect us.  In the future when Xen supports the other 
Fedora Extras archs, then we may have buildroots within Xen virtual 
machines, further isolated from actual hardware.

It does sound though that generally it isn't a good idea to leave "make 
check" enabled in this case.  Accessing almost any resource outside of 
the buildroot should be forbidden during rpmbuild.

Warren Togami
wtogami at redhat.com