[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Request for review: gnome-applet-bubblemon



Ignacio Vazquez-Abrams pointed out these mistakes:

>- Remove the hardcoded disttags
>- Remove the explicit Requires
>- --prefix and --mandir are redundant with %configure
>- Variables should come after make in the command line, not before
>- Use install, not install-strip in %install
>- Should not own %{_datadir}/gnome-2.0
>- Use %find_lang instead of owning %{_datadir}/locale

I've updated the package and here you can find it.

SPEC:http://www.cs.famaf.unc.edu.ar/~nicolasw/Otros/gnome-applet-bubblemon.spec
SRPM:http://www.cs.famaf.unc.edu.ar/~nicolasw/Otros/gnome-applet-bubblemon-2.0.4-3.src.rpm

Regards, Nicolas


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]